diff mbox series

[net-next] qed/qede: Remove unused declarations

Message ID 20230821130002.36700-1-yuehaibing@huawei.com (mailing list archive)
State Accepted
Commit eb6603246ab9a3787e9603f0fd6a321b46623e46
Delegated to: Netdev Maintainers
Headers show
Series [net-next] qed/qede: Remove unused declarations | expand

Checks

Context Check Description
netdev/series_format success Single patches do not need cover letters
netdev/tree_selection success Clearly marked for net-next
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 1391 this patch: 1391
netdev/cc_maintainers success CCed 7 of 7 maintainers
netdev/build_clang success Errors and warnings before: 1353 this patch: 1353
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 1414 this patch: 1414
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 25 lines checked
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0

Commit Message

Yue Haibing Aug. 21, 2023, 1 p.m. UTC
Commit 8cd160a29415 ("qede: convert to new udp_tunnel_nic infra")
removed qede_udp_tunnel_{add,del}() but not the declarations.
Commit 0ebcebbef1cc ("qed: Read device port count from the shmem")
removed qed_device_num_engines() but not its declaration.
Commit 1e128c81290a ("qed: Add support for hardware offloaded FCoE.")
declared but never implemented qed_fcoe_set_pf_params().

Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
---
 drivers/net/ethernet/qlogic/qed/qed.h   | 1 -
 drivers/net/ethernet/qlogic/qede/qede.h | 3 ---
 include/linux/qed/qed_fcoe_if.h         | 3 ---
 3 files changed, 7 deletions(-)

Comments

Simon Horman Aug. 21, 2023, 7:51 p.m. UTC | #1
On Mon, Aug 21, 2023 at 09:00:02PM +0800, Yue Haibing wrote:
> Commit 8cd160a29415 ("qede: convert to new udp_tunnel_nic infra")
> removed qede_udp_tunnel_{add,del}() but not the declarations.
> Commit 0ebcebbef1cc ("qed: Read device port count from the shmem")
> removed qed_device_num_engines() but not its declaration.
> Commit 1e128c81290a ("qed: Add support for hardware offloaded FCoE.")
> declared but never implemented qed_fcoe_set_pf_params().
> 
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>

Reviewed-by: Simon Horman <horms@kernel.org>
patchwork-bot+netdevbpf@kernel.org Aug. 23, 2023, 7:30 a.m. UTC | #2
Hello:

This patch was applied to netdev/net-next.git (main)
by David S. Miller <davem@davemloft.net>:

On Mon, 21 Aug 2023 21:00:02 +0800 you wrote:
> Commit 8cd160a29415 ("qede: convert to new udp_tunnel_nic infra")
> removed qede_udp_tunnel_{add,del}() but not the declarations.
> Commit 0ebcebbef1cc ("qed: Read device port count from the shmem")
> removed qed_device_num_engines() but not its declaration.
> Commit 1e128c81290a ("qed: Add support for hardware offloaded FCoE.")
> declared but never implemented qed_fcoe_set_pf_params().
> 
> [...]

Here is the summary with links:
  - [net-next] qed/qede: Remove unused declarations
    https://git.kernel.org/netdev/net-next/c/eb6603246ab9

You are awesome, thank you!
diff mbox series

Patch

diff --git a/drivers/net/ethernet/qlogic/qed/qed.h b/drivers/net/ethernet/qlogic/qed/qed.h
index d613095b78e0..1d719726f72b 100644
--- a/drivers/net/ethernet/qlogic/qed/qed.h
+++ b/drivers/net/ethernet/qlogic/qed/qed.h
@@ -909,7 +909,6 @@  void qed_configure_vp_wfq_on_link_change(struct qed_dev *cdev,
 					 u32 min_pf_rate);
 
 void qed_clean_wfq_db(struct qed_hwfn *p_hwfn, struct qed_ptt *p_ptt);
-int qed_device_num_engines(struct qed_dev *cdev);
 void qed_set_fw_mac_addr(__le16 *fw_msb,
 			 __le16 *fw_mid, __le16 *fw_lsb, u8 *mac);
 
diff --git a/drivers/net/ethernet/qlogic/qede/qede.h b/drivers/net/ethernet/qlogic/qede/qede.h
index 4d83ceebdc49..042a75f34060 100644
--- a/drivers/net/ethernet/qlogic/qede/qede.h
+++ b/drivers/net/ethernet/qlogic/qede/qede.h
@@ -556,9 +556,6 @@  void qede_config_rx_mode(struct net_device *ndev);
 void qede_fill_rss_params(struct qede_dev *edev,
 			  struct qed_update_vport_rss_params *rss, u8 *update);
 
-void qede_udp_tunnel_add(struct net_device *dev, struct udp_tunnel_info *ti);
-void qede_udp_tunnel_del(struct net_device *dev, struct udp_tunnel_info *ti);
-
 int qede_xdp(struct net_device *dev, struct netdev_bpf *xdp);
 
 #ifdef CONFIG_DCB
diff --git a/include/linux/qed/qed_fcoe_if.h b/include/linux/qed/qed_fcoe_if.h
index 90e3045b2dcb..0d3b6ed21628 100644
--- a/include/linux/qed/qed_fcoe_if.h
+++ b/include/linux/qed/qed_fcoe_if.h
@@ -67,9 +67,6 @@  struct qed_fcoe_cb_ops {
 	 u32 (*get_login_failures)(void *cookie);
 };
 
-void qed_fcoe_set_pf_params(struct qed_dev *cdev,
-			    struct qed_fcoe_pf_params *params);
-
 /**
  * struct qed_fcoe_ops - qed FCoE operations.
  * @common:		common operations pointer