diff mbox series

[net-next] net: mscc: ocelot: Remove unused declarations

Message ID 20230821130218.19096-1-yuehaibing@huawei.com (mailing list archive)
State Accepted
Commit 49e62a0462a2d669e35f97eb3e0a6f2aab20518d
Delegated to: Netdev Maintainers
Headers show
Series [net-next] net: mscc: ocelot: Remove unused declarations | expand

Checks

Context Check Description
netdev/series_format success Single patches do not need cover letters
netdev/tree_selection success Clearly marked for net-next
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 1330 this patch: 1330
netdev/cc_maintainers warning 1 maintainers not CCed: edumazet@google.com
netdev/build_clang success Errors and warnings before: 1353 this patch: 1353
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 1353 this patch: 1353
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 22 lines checked
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0

Commit Message

Yue Haibing Aug. 21, 2023, 1:02 p.m. UTC
Commit 6c30384eb1de ("net: mscc: ocelot: register devlink ports")
declared but never implemented ocelot_devlink_init() and
ocelot_devlink_teardown().
Commit 2096805497e2 ("net: mscc: ocelot: automatically detect VCAP constants")
declared but never implemented ocelot_detect_vcap_constants().
Commit 403ffc2c34de ("net: mscc: ocelot: add support for preemptible traffic classes")
declared but never implemented ocelot_port_update_preemptible_tcs().

Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
---
 drivers/net/ethernet/mscc/ocelot.h      | 2 --
 drivers/net/ethernet/mscc/ocelot_vcap.h | 1 -
 include/soc/mscc/ocelot.h               | 1 -
 3 files changed, 4 deletions(-)

Comments

Vladimir Oltean Aug. 21, 2023, 1:08 p.m. UTC | #1
On Mon, Aug 21, 2023 at 09:02:18PM +0800, Yue Haibing wrote:
> Commit 6c30384eb1de ("net: mscc: ocelot: register devlink ports")
> declared but never implemented ocelot_devlink_init() and
> ocelot_devlink_teardown().
> Commit 2096805497e2 ("net: mscc: ocelot: automatically detect VCAP constants")
> declared but never implemented ocelot_detect_vcap_constants().
> Commit 403ffc2c34de ("net: mscc: ocelot: add support for preemptible traffic classes")
> declared but never implemented ocelot_port_update_preemptible_tcs().
> 
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
> ---

Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
patchwork-bot+netdevbpf@kernel.org Aug. 22, 2023, 6 p.m. UTC | #2
Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Mon, 21 Aug 2023 21:02:18 +0800 you wrote:
> Commit 6c30384eb1de ("net: mscc: ocelot: register devlink ports")
> declared but never implemented ocelot_devlink_init() and
> ocelot_devlink_teardown().
> Commit 2096805497e2 ("net: mscc: ocelot: automatically detect VCAP constants")
> declared but never implemented ocelot_detect_vcap_constants().
> Commit 403ffc2c34de ("net: mscc: ocelot: add support for preemptible traffic classes")
> declared but never implemented ocelot_port_update_preemptible_tcs().
> 
> [...]

Here is the summary with links:
  - [net-next] net: mscc: ocelot: Remove unused declarations
    https://git.kernel.org/netdev/net-next/c/49e62a0462a2

You are awesome, thank you!
diff mbox series

Patch

diff --git a/drivers/net/ethernet/mscc/ocelot.h b/drivers/net/ethernet/mscc/ocelot.h
index 87f2055c242c..e50be508c166 100644
--- a/drivers/net/ethernet/mscc/ocelot.h
+++ b/drivers/net/ethernet/mscc/ocelot.h
@@ -97,8 +97,6 @@  int ocelot_netdev_to_port(struct net_device *dev);
 int ocelot_probe_port(struct ocelot *ocelot, int port, struct regmap *target,
 		      struct device_node *portnp);
 void ocelot_release_port(struct ocelot_port *ocelot_port);
-int ocelot_devlink_init(struct ocelot *ocelot);
-void ocelot_devlink_teardown(struct ocelot *ocelot);
 int ocelot_port_devlink_init(struct ocelot *ocelot, int port,
 			     enum devlink_port_flavour flavour);
 void ocelot_port_devlink_teardown(struct ocelot *ocelot, int port);
diff --git a/drivers/net/ethernet/mscc/ocelot_vcap.h b/drivers/net/ethernet/mscc/ocelot_vcap.h
index 523611ccc48f..6f546695faa5 100644
--- a/drivers/net/ethernet/mscc/ocelot_vcap.h
+++ b/drivers/net/ethernet/mscc/ocelot_vcap.h
@@ -15,7 +15,6 @@ 
 int ocelot_vcap_filter_stats_update(struct ocelot *ocelot,
 				    struct ocelot_vcap_filter *rule);
 
-void ocelot_detect_vcap_constants(struct ocelot *ocelot);
 int ocelot_vcap_init(struct ocelot *ocelot);
 
 int ocelot_setup_tc_cls_flower(struct ocelot_port_private *priv,
diff --git a/include/soc/mscc/ocelot.h b/include/soc/mscc/ocelot.h
index a8c2817335b9..1e1b40f4e664 100644
--- a/include/soc/mscc/ocelot.h
+++ b/include/soc/mscc/ocelot.h
@@ -1165,7 +1165,6 @@  int ocelot_port_get_mm(struct ocelot *ocelot, int port,
 		       struct ethtool_mm_state *state);
 int ocelot_port_mqprio(struct ocelot *ocelot, int port,
 		       struct tc_mqprio_qopt_offload *mqprio);
-void ocelot_port_update_preemptible_tcs(struct ocelot *ocelot, int port);
 
 #if IS_ENABLED(CONFIG_BRIDGE_MRP)
 int ocelot_mrp_add(struct ocelot *ocelot, int port,