diff mbox series

[v1,4/5] perf test: Ensure EXTRA_TESTS is covered in build test

Message ID 20230914211948.814999-5-irogers@google.com (mailing list archive)
State Handled Elsewhere
Delegated to: BPF
Headers show
Series Enable BPF skeletons by default | expand

Checks

Context Check Description
netdev/tree_selection success Not a local patch
bpf/vmtest-bpf-PR fail merge-conflict

Commit Message

Ian Rogers Sept. 14, 2023, 9:19 p.m. UTC 
Add to run variable.

Signed-off-by: Ian Rogers <irogers@google.com>
---
 tools/perf/tests/make | 1 +
 1 file changed, 1 insertion(+)

Comments

Namhyung Kim Sept. 18, 2023, 11:34 p.m. UTC | #1 
Hi Ian,

On Thu, Sep 14, 2023 at 2:20 PM Ian Rogers <irogers@google.com> wrote:
>
> Add to run variable.
>
> Signed-off-by: Ian Rogers <irogers@google.com>
> ---
>  tools/perf/tests/make | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/tools/perf/tests/make b/tools/perf/tests/make
> index a3a0f2a8bba0..d9945ed25bc5 100644
> --- a/tools/perf/tests/make
> +++ b/tools/perf/tests/make
> @@ -138,6 +138,7 @@ endif
>  run += make_python_perf_so
>  run += make_debug
>  run += make_nondistro
> +run += make_extra_tests

I'm curious why it's missed.. I couldn't find a commit to delete it.
Maybe due to an incorrect resolution of a merge conflict?

Thanks,
Namhyung


>  run += make_no_bpf_skel
>  run += make_gen_vmlinux_h
>  run += make_no_libperl
> --
> 2.42.0.459.ge4e396fd5e-goog
>
Ian Rogers Sept. 19, 2023, 2:15 a.m. UTC | #2 
On Mon, Sep 18, 2023 at 4:34 PM Namhyung Kim <namhyung@kernel.org> wrote:
>
> Hi Ian,
>
> On Thu, Sep 14, 2023 at 2:20 PM Ian Rogers <irogers@google.com> wrote:
> >
> > Add to run variable.
> >
> > Signed-off-by: Ian Rogers <irogers@google.com>
> > ---
> >  tools/perf/tests/make | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/tools/perf/tests/make b/tools/perf/tests/make
> > index a3a0f2a8bba0..d9945ed25bc5 100644
> > --- a/tools/perf/tests/make
> > +++ b/tools/perf/tests/make
> > @@ -138,6 +138,7 @@ endif
> >  run += make_python_perf_so
> >  run += make_debug
> >  run += make_nondistro
> > +run += make_extra_tests
>
> I'm curious why it's missed.. I couldn't find a commit to delete it.
> Maybe due to an incorrect resolution of a merge conflict?

I think it was just a mistake in the original patch:
https://lore.kernel.org/lkml/683fea7c-f5e9-fa20-f96b-f6233ed5d2a7@intel.com/

Thanks,
Ian

> Thanks,
> Namhyung
>
>
> >  run += make_no_bpf_skel
> >  run += make_gen_vmlinux_h
> >  run += make_no_libperl
> > --
> > 2.42.0.459.ge4e396fd5e-goog
> >
diff mbox series

Patch

diff --git a/tools/perf/tests/make b/tools/perf/tests/make
index a3a0f2a8bba0..d9945ed25bc5 100644
--- a/tools/perf/tests/make
+++ b/tools/perf/tests/make
@@ -138,6 +138,7 @@  endif
 run += make_python_perf_so
 run += make_debug
 run += make_nondistro
+run += make_extra_tests
 run += make_no_bpf_skel
 run += make_gen_vmlinux_h
 run += make_no_libperl