| Message ID | 20230919010305.120991-1-yang.lee@linux.alibaba.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | f20161cf51657bf4c85380c0c1c80188a74f168d |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] netdev: Remove unneeded semicolon | expand |
On 19/09/2023 02:03, Yang Li wrote: > ./drivers/dpll/dpll_netlink.c:847:3-4: Unneeded semicolon > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6605 > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> Hi Yang! There was a report from Intel's bot too about the issue, could you please add the tags from it? Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202309190540.RFwfIgO7-lkp@intel.com/ Thanks! > --- > drivers/dpll/dpll_netlink.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/dpll/dpll_netlink.c b/drivers/dpll/dpll_netlink.c > index 764437a0661b..e20daba6896a 100644 > --- a/drivers/dpll/dpll_netlink.c > +++ b/drivers/dpll/dpll_netlink.c > @@ -844,7 +844,7 @@ dpll_pin_find(u64 clock_id, struct nlattr *mod_name_attr, > return ERR_PTR(-EINVAL); > } > pin_match = pin; > - }; > + } > } > if (!pin_match) { > NL_SET_ERR_MSG(extack, "not found");
On Wed, 2023-09-20 at 12:10 +0100, Vadim Fedorenko wrote: > On 19/09/2023 02:03, Yang Li wrote: > > ./drivers/dpll/dpll_netlink.c:847:3-4: Unneeded semicolon > > > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6605 > > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> > > Hi Yang! > There was a report from Intel's bot too about the issue, could you > please add the tags from it? > > Reported-by: kernel test robot <lkp@intel.com> > Closes: > https://lore.kernel.org/oe-kbuild-all/202309190540.RFwfIgO7-lkp@intel.com/ No need to repost, the pw tools import the above tags automatically. Cheers, Paolo
Hello: This patch was applied to netdev/net-next.git (main) by Paolo Abeni <pabeni@redhat.com>: On Tue, 19 Sep 2023 09:03:05 +0800 you wrote: > ./drivers/dpll/dpll_netlink.c:847:3-4: Unneeded semicolon > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6605 > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> > --- > drivers/dpll/dpll_netlink.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Here is the summary with links: - [net-next] netdev: Remove unneeded semicolon https://git.kernel.org/netdev/net-next/c/f20161cf5165 You are awesome, thank you!
On 21/09/2023 14:07, Paolo Abeni wrote: > On Wed, 2023-09-20 at 12:10 +0100, Vadim Fedorenko wrote: >> On 19/09/2023 02:03, Yang Li wrote: >>> ./drivers/dpll/dpll_netlink.c:847:3-4: Unneeded semicolon >>> >>> Reported-by: Abaci Robot <abaci@linux.alibaba.com> >>> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6605 >>> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> >> >> Hi Yang! >> There was a report from Intel's bot too about the issue, could you >> please add the tags from it? >> >> Reported-by: kernel test robot <lkp@intel.com> >> Closes: >> https://lore.kernel.org/oe-kbuild-all/202309190540.RFwfIgO7-lkp@intel.com/ > > No need to repost, the pw tools import the above tags automatically. Ok, cool. The fix itself is trivial. Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
diff --git a/drivers/dpll/dpll_netlink.c b/drivers/dpll/dpll_netlink.c index 764437a0661b..e20daba6896a 100644 --- a/drivers/dpll/dpll_netlink.c +++ b/drivers/dpll/dpll_netlink.c @@ -844,7 +844,7 @@ dpll_pin_find(u64 clock_id, struct nlattr *mod_name_attr, return ERR_PTR(-EINVAL); } pin_match = pin; - }; + } } if (!pin_match) { NL_SET_ERR_MSG(extack, "not found");
./drivers/dpll/dpll_netlink.c:847:3-4: Unneeded semicolon Reported-by: Abaci Robot <abaci@linux.alibaba.com> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6605 Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> --- drivers/dpll/dpll_netlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)