| Message ID | 20230919094021.24699-1-colin.i.king@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | ccd663caffc7b5158a0a841b70618d9e87da531c |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [next] net: dsa: mv88e6xxx: make const read-only array lanes static | expand |
On Tue, Sep 19, 2023 at 10:40:21AM +0100, Colin Ian King wrote: > Don't populate the const read-only array lanes on the stack, instead make > it static. > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
Hello: This patch was applied to netdev/net-next.git (main) by David S. Miller <davem@davemloft.net>: On Tue, 19 Sep 2023 10:40:21 +0100 you wrote: > Don't populate the const read-only array lanes on the stack, instead make > it static. > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> > --- > drivers/net/dsa/mv88e6xxx/pcs-639x.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Here is the summary with links: - [next] net: dsa: mv88e6xxx: make const read-only array lanes static https://git.kernel.org/netdev/net-next/c/ccd663caffc7 You are awesome, thank you!
diff --git a/drivers/net/dsa/mv88e6xxx/pcs-639x.c b/drivers/net/dsa/mv88e6xxx/pcs-639x.c index ba373656bfe1..9a8429f5d09c 100644 --- a/drivers/net/dsa/mv88e6xxx/pcs-639x.c +++ b/drivers/net/dsa/mv88e6xxx/pcs-639x.c @@ -208,7 +208,7 @@ static void mv88e639x_sgmii_pcs_pre_config(struct phylink_pcs *pcs, static int mv88e6390_erratum_3_14(struct mv88e639x_pcs *mpcs) { - const int lanes[] = { MV88E6390_PORT9_LANE0, MV88E6390_PORT9_LANE1, + static const int lanes[] = { MV88E6390_PORT9_LANE0, MV88E6390_PORT9_LANE1, MV88E6390_PORT9_LANE2, MV88E6390_PORT9_LANE3, MV88E6390_PORT10_LANE0, MV88E6390_PORT10_LANE1, MV88E6390_PORT10_LANE2, MV88E6390_PORT10_LANE3 };
Don't populate the const read-only array lanes on the stack, instead make it static. Signed-off-by: Colin Ian King <colin.i.king@gmail.com> --- drivers/net/dsa/mv88e6xxx/pcs-639x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)