diff mbox series

[net-next] MAINTAINERS: Add an obsolete entry for LL TEMAC driver

Message ID 20230920115047.31345-1-harini.katakam@amd.com (mailing list archive)
State Accepted
Commit 19f5eef8bf732406415b44783ea623e3a31c34c9
Delegated to: Netdev Maintainers
Headers show
Series [net-next] MAINTAINERS: Add an obsolete entry for LL TEMAC driver | expand

Checks

Context Check Description
netdev/series_format success Single patches do not need cover letters
netdev/tree_selection success Clearly marked for net-next
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 9 this patch: 9
netdev/cc_maintainers success CCed 0 of 0 maintainers
netdev/build_clang success Errors and warnings before: 9 this patch: 9
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 9 this patch: 9
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 11 lines checked
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0

Commit Message

Katakam, Harini Sept. 20, 2023, 11:50 a.m. UTC
LL TEMAC IP is no longer supported. Hence add an entry marking the
driver as obsolete.

Signed-off-by: Harini Katakam <harini.katakam@amd.com>
---
This is an old driver with no bindings doc and hence the maintainers
entry does not contain a link to documentation.
---
 MAINTAINERS | 5 +++++
 1 file changed, 5 insertions(+)

Comments

patchwork-bot+netdevbpf@kernel.org Sept. 28, 2023, 2:10 p.m. UTC | #1
Hello:

This patch was applied to netdev/net-next.git (main)
by Paolo Abeni <pabeni@redhat.com>:

On Wed, 20 Sep 2023 17:20:47 +0530 you wrote:
> LL TEMAC IP is no longer supported. Hence add an entry marking the
> driver as obsolete.
> 
> Signed-off-by: Harini Katakam <harini.katakam@amd.com>
> ---
> This is an old driver with no bindings doc and hence the maintainers
> entry does not contain a link to documentation.
> 
> [...]

Here is the summary with links:
  - [net-next] MAINTAINERS: Add an obsolete entry for LL TEMAC driver
    https://git.kernel.org/netdev/net-next/c/19f5eef8bf73

You are awesome, thank you!
Esben Haabendal Sept. 28, 2023, 2:46 p.m. UTC | #2
Harini Katakam <harini.katakam@amd.com> writes:

> LL TEMAC IP is no longer supported. Hence add an entry marking the
> driver as obsolete.

Ok. But while that might mean that no new designs should use LL TEMAC
IP, why do we need to declare the driver for it obsolete?

Existing designs using LL TEMAC IP might need to upgrade Linux kernel
also.

/Esben

>
> Signed-off-by: Harini Katakam <harini.katakam@amd.com>
> ---
> This is an old driver with no bindings doc and hence the maintainers
> entry does not contain a link to documentation.
> ---
>  MAINTAINERS | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 3dde038545d8..820a7817f02f 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -23696,6 +23696,11 @@ F:	Documentation/devicetree/bindings/gpio/xlnx,gpio-xilinx.yaml
>  F:	drivers/gpio/gpio-xilinx.c
>  F:	drivers/gpio/gpio-zynq.c
>  
> +XILINX LL TEMAC ETHERNET DRIVER
> +L:	netdev@vger.kernel.org
> +S:	Obsolete
> +F:	drivers/net/ethernet/xilinx/ll_temac*
> +
>  XILINX PWM DRIVER
>  M:	Sean Anderson <sean.anderson@seco.com>
>  S:	Maintained
Michal Simek Sept. 29, 2023, 6:06 a.m. UTC | #3
On 9/28/23 16:46, esben@geanix.com wrote:
> Harini Katakam <harini.katakam@amd.com> writes:
> 
>> LL TEMAC IP is no longer supported. Hence add an entry marking the
>> driver as obsolete.
> 
> Ok. But while that might mean that no new designs should use LL TEMAC
> IP, why do we need to declare the driver for it obsolete?
> 
> Existing designs using LL TEMAC IP might need to upgrade Linux kernel
> also.

If you want to take responsibility for keeping that driver alive then feel free 
to send a patch on the top and declare it publicly. We are not able to test it 
on these old platforms that's why we are publicly saying that it is end of us.

Thanks,
Michal
Jakub Kicinski Oct. 4, 2023, 2:46 p.m. UTC | #4
On Fri, 29 Sep 2023 08:06:46 +0200 Michal Simek wrote:
> > Ok. But while that might mean that no new designs should use LL TEMAC
> > IP, why do we need to declare the driver for it obsolete?
> > 
> > Existing designs using LL TEMAC IP might need to upgrade Linux kernel
> > also.  
> 
> If you want to take responsibility for keeping that driver alive then feel free 
> to send a patch on the top and declare it publicly. We are not able to test it 
> on these old platforms that's why we are publicly saying that it is end of us.

Why Obsolete tho? There's no other driver for this IP, so Orphan sounds
more accurate. Please change it to Orphan.
Katakam, Harini Oct. 5, 2023, 1:12 p.m. UTC | #5
Hi Jakub,

> -----Original Message-----
> From: Jakub Kicinski <kuba@kernel.org>
> Sent: Wednesday, October 4, 2023 8:17 PM
> To: Simek, Michal <michal.simek@amd.com>
> Cc: esben@geanix.com; Katakam, Harini <harini.katakam@amd.com>;
> davem@davemloft.net; edumazet@google.com; pabeni@redhat.com;
> jsc@umbraculum.org; christophe.jaillet@wanadoo.fr;
> netdev@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
> kernel@vger.kernel.org; harinikatakamlinux@gmail.com; Pandey, Radhey
> Shyam <radhey.shyam.pandey@amd.com>
> Subject: Re: [PATCH net-next] MAINTAINERS: Add an obsolete entry for LL
> TEMAC driver
> 
> On Fri, 29 Sep 2023 08:06:46 +0200 Michal Simek wrote:
> > > Ok. But while that might mean that no new designs should use LL TEMAC
> > > IP, why do we need to declare the driver for it obsolete?
> > >
> > > Existing designs using LL TEMAC IP might need to upgrade Linux kernel
> > > also.
> >
> > If you want to take responsibility for keeping that driver alive then feel free
> > to send a patch on the top and declare it publicly. We are not able to test it
> > on these old platforms that's why we are publicly saying that it is end of us.
> 
> Why Obsolete tho? There's no other driver for this IP, so Orphan sounds
> more accurate. Please change it to Orphan.

I just noticed that this patch was already applied on net-next. So, I sent a patch
on top updating it from Obsolete to Orphan.

Regards,
Harini
diff mbox series

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index 3dde038545d8..820a7817f02f 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -23696,6 +23696,11 @@  F:	Documentation/devicetree/bindings/gpio/xlnx,gpio-xilinx.yaml
 F:	drivers/gpio/gpio-xilinx.c
 F:	drivers/gpio/gpio-zynq.c
 
+XILINX LL TEMAC ETHERNET DRIVER
+L:	netdev@vger.kernel.org
+S:	Obsolete
+F:	drivers/net/ethernet/xilinx/ll_temac*
+
 XILINX PWM DRIVER
 M:	Sean Anderson <sean.anderson@seco.com>
 S:	Maintained