| Message ID | 20231006214421.339445-1-robh@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | f0107b864f004bc6fa19bf6d5074b4a366f3e16a |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | atm: fore200e: Drop unnecessary of_match_device() | expand |
On Fri, Oct 06, 2023 at 04:44:21PM -0500, Rob Herring wrote: > It is not necessary to call of_match_device() in probe. If we made it to > probe, then we've already successfully matched. > > Signed-off-by: Rob Herring <robh@kernel.org> I agree that the check is redundant. And that with it removed, the forward declaration of fore200e_sba_match is no longer needed. Minor nit: I assume the target tree is net-next. Ideally that would be specified. Subject: [PATCH net-net] ... Reviewed-by: Simon Horman <horms@kernel.org>
Hello: This patch was applied to netdev/net-next.git (main) by Paolo Abeni <pabeni@redhat.com>: On Fri, 6 Oct 2023 16:44:21 -0500 you wrote: > It is not necessary to call of_match_device() in probe. If we made it to > probe, then we've already successfully matched. > > Signed-off-by: Rob Herring <robh@kernel.org> > --- > drivers/atm/fore200e.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) Here is the summary with links: - atm: fore200e: Drop unnecessary of_match_device() https://git.kernel.org/netdev/net-next/c/f0107b864f00 You are awesome, thank you!
diff --git a/drivers/atm/fore200e.c b/drivers/atm/fore200e.c index fb2be3574c26..50d8ce20ae5b 100644 --- a/drivers/atm/fore200e.c +++ b/drivers/atm/fore200e.c @@ -36,7 +36,7 @@ #ifdef CONFIG_SBUS #include <linux/of.h> -#include <linux/of_device.h> +#include <linux/platform_device.h> #include <asm/idprom.h> #include <asm/openprom.h> #include <asm/oplib.h> @@ -2520,18 +2520,12 @@ static int fore200e_init(struct fore200e *fore200e, struct device *parent) } #ifdef CONFIG_SBUS -static const struct of_device_id fore200e_sba_match[]; static int fore200e_sba_probe(struct platform_device *op) { - const struct of_device_id *match; struct fore200e *fore200e; static int index = 0; int err; - match = of_match_device(fore200e_sba_match, &op->dev); - if (!match) - return -EINVAL; - fore200e = kzalloc(sizeof(struct fore200e), GFP_KERNEL); if (!fore200e) return -ENOMEM;
It is not necessary to call of_match_device() in probe. If we made it to probe, then we've already successfully matched. Signed-off-by: Rob Herring <robh@kernel.org> --- drivers/atm/fore200e.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-)