diff mbox series

[net-next,v4,3/4] MAINTAINERS: add Rust PHY abstractions to the ETHERNET PHY LIBRARY

Message ID 20231012125349.2702474-4-fujita.tomonori@gmail.com (mailing list archive)
State Superseded
Delegated to: Netdev Maintainers
Headers show
Series Rust abstractions for network PHY drivers | expand

Checks

Context Check Description
netdev/series_format success Posting correctly formatted
netdev/tree_selection success Clearly marked for net-next
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 9 this patch: 9
netdev/cc_maintainers warning 5 maintainers not CCed: bjorn3_gh@protonmail.com alex.gaynor@gmail.com aliceryhl@google.com gary@garyguo.net a.hindborg@samsung.com
netdev/build_clang success Errors and warnings before: 9 this patch: 9
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 9 this patch: 9
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 14 lines checked
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0

Commit Message

FUJITA Tomonori Oct. 12, 2023, 12:53 p.m. UTC 
Adds me as a maintainer for these Rust bindings too.

The files are placed at rust/kernel/ directory for now but the files
are likely to be moved to net/ directory once a new Rust build system
is implemented.

Signed-off-by: FUJITA Tomonori <fujita.tomonori@gmail.com>
---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)

Comments

Boqun Feng Oct. 13, 2023, 2:34 p.m. UTC | #1 
On Thu, Oct 12, 2023 at 09:53:48PM +0900, FUJITA Tomonori wrote:
> Adds me as a maintainer for these Rust bindings too.
> 
> The files are placed at rust/kernel/ directory for now but the files
> are likely to be moved to net/ directory once a new Rust build system
> is implemented.
> 
> Signed-off-by: FUJITA Tomonori <fujita.tomonori@gmail.com>
> ---
>  MAINTAINERS | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 698ebbd78075..eb51a1d526b7 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -7770,6 +7770,7 @@ F:	net/bridge/
>  ETHERNET PHY LIBRARY
>  M:	Andrew Lunn <andrew@lunn.ch>
>  M:	Heiner Kallweit <hkallweit1@gmail.com>
> +M:	FUJITA Tomonori <fujita.tomonori@gmail.com>
>  R:	Russell King <linux@armlinux.org.uk>

Since Trevor has been reviewing the series and showed a lot of
expertise, I suggest having him as the reviewer in Rust networking, of
course if he and everyone agree ;-)

Trevor, what do you think?

Regards,
Boqun

>  L:	netdev@vger.kernel.org
>  S:	Maintained
> @@ -7799,6 +7800,7 @@ F:	include/trace/events/mdio.h
>  F:	include/uapi/linux/mdio.h
>  F:	include/uapi/linux/mii.h
>  F:	net/core/of_net.c
> +F:	rust/kernel/net/phy.rs
>  
>  EXEC & BINFMT API
>  R:	Eric Biederman <ebiederm@xmission.com>
> -- 
> 2.34.1
>
FUJITA Tomonori Oct. 13, 2023, 3:24 p.m. UTC | #2 
On Fri, 13 Oct 2023 07:34:40 -0700
Boqun Feng <boqun.feng@gmail.com> wrote:

> On Thu, Oct 12, 2023 at 09:53:48PM +0900, FUJITA Tomonori wrote:
>> Adds me as a maintainer for these Rust bindings too.
>> 
>> The files are placed at rust/kernel/ directory for now but the files
>> are likely to be moved to net/ directory once a new Rust build system
>> is implemented.
>> 
>> Signed-off-by: FUJITA Tomonori <fujita.tomonori@gmail.com>
>> ---
>>  MAINTAINERS | 2 ++
>>  1 file changed, 2 insertions(+)
>> 
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 698ebbd78075..eb51a1d526b7 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -7770,6 +7770,7 @@ F:	net/bridge/
>>  ETHERNET PHY LIBRARY
>>  M:	Andrew Lunn <andrew@lunn.ch>
>>  M:	Heiner Kallweit <hkallweit1@gmail.com>
>> +M:	FUJITA Tomonori <fujita.tomonori@gmail.com>
>>  R:	Russell King <linux@armlinux.org.uk>
> 
> Since Trevor has been reviewing the series and showed a lot of
> expertise, I suggest having him as the reviewer in Rust networking, of
> course if he and everyone agree ;-)

There is no such thing as Rust networking :) This is PHYLIB entry.

If it's ok with the PHYLIB maintainers and Trevor, I'm happy to add
him.
Boqun Feng Oct. 13, 2023, 4:10 p.m. UTC | #3 
On Sat, Oct 14, 2023 at 12:24:31AM +0900, FUJITA Tomonori wrote:
> On Fri, 13 Oct 2023 07:34:40 -0700
> Boqun Feng <boqun.feng@gmail.com> wrote:
> 
> > On Thu, Oct 12, 2023 at 09:53:48PM +0900, FUJITA Tomonori wrote:
> >> Adds me as a maintainer for these Rust bindings too.
> >> 
> >> The files are placed at rust/kernel/ directory for now but the files
> >> are likely to be moved to net/ directory once a new Rust build system
> >> is implemented.
> >> 
> >> Signed-off-by: FUJITA Tomonori <fujita.tomonori@gmail.com>
> >> ---
> >>  MAINTAINERS | 2 ++
> >>  1 file changed, 2 insertions(+)
> >> 
> >> diff --git a/MAINTAINERS b/MAINTAINERS
> >> index 698ebbd78075..eb51a1d526b7 100644
> >> --- a/MAINTAINERS
> >> +++ b/MAINTAINERS
> >> @@ -7770,6 +7770,7 @@ F:	net/bridge/
> >>  ETHERNET PHY LIBRARY
> >>  M:	Andrew Lunn <andrew@lunn.ch>
> >>  M:	Heiner Kallweit <hkallweit1@gmail.com>
> >> +M:	FUJITA Tomonori <fujita.tomonori@gmail.com>
> >>  R:	Russell King <linux@armlinux.org.uk>
> > 
> > Since Trevor has been reviewing the series and showed a lot of
> > expertise, I suggest having him as the reviewer in Rust networking, of
> > course if he and everyone agree ;-)
> 
> There is no such thing as Rust networking :) This is PHYLIB entry.
> 

Right, my bad ;-)

> If it's ok with the PHYLIB maintainers and Trevor, I'm happy to add
> him.

Thanks!

Regards,
Boqun
Trevor Gross Oct. 13, 2023, 4:17 p.m. UTC | #4 
On Fri, Oct 13, 2023 at 10:34 AM Boqun Feng <boqun.feng@gmail.com> wrote:
> Since Trevor has been reviewing the series and showed a lot of
> expertise, I suggest having him as the reviewer in Rust networking, of
> course if he and everyone agree ;-)
>
> Trevor, what do you think?
>
> Regards,
> Boqun

Thanks for the suggestion Boqun :) I would be happy to be a reviewer
for the rust components of networking.

As Tomo mentioned I am not sure there is a good way to indicate this
niche, maybe a new section with two lists? Andrew's call for what
would be best here I suppose.
Miguel Ojeda Oct. 13, 2023, 6:43 p.m. UTC | #5 
On Fri, Oct 13, 2023 at 6:17 PM Trevor Gross <tmgross@umich.edu> wrote:
>
> Thanks for the suggestion Boqun :) I would be happy to be a reviewer
> for the rust components of networking.

Thanks a lot Trevor!

> As Tomo mentioned I am not sure there is a good way to indicate this
> niche, maybe a new section with two lists? Andrew's call for what
> would be best here I suppose.

Yes, maintainers may prefer to split it or not (e.g. "ETHERNET PHY
LIBRARY [RUST]"). Then Tomo and you can be there.

That also allows to list only the relevant files in `F:`, to have an
extra `L:` for rust-for-linux (in the beginning), a different `S:`
level if needed, etc.

Cheers,
Miguel
Andrew Lunn Oct. 13, 2023, 6:49 p.m. UTC | #6 
On Fri, Oct 13, 2023 at 08:43:21PM +0200, Miguel Ojeda wrote:
> On Fri, Oct 13, 2023 at 6:17 PM Trevor Gross <tmgross@umich.edu> wrote:
> >
> > Thanks for the suggestion Boqun :) I would be happy to be a reviewer
> > for the rust components of networking.
> 
> Thanks a lot Trevor!
> 
> > As Tomo mentioned I am not sure there is a good way to indicate this
> > niche, maybe a new section with two lists? Andrew's call for what
> > would be best here I suppose.
> 
> Yes, maintainers may prefer to split it or not (e.g. "ETHERNET PHY
> LIBRARY [RUST]"). Then Tomo and you can be there.
> 
> That also allows to list only the relevant files in `F:`, to have an
> extra `L:` for rust-for-linux (in the beginning), a different `S:`
> level if needed, etc.

Yes, this seems sensible.

I would also suggest a new entry for the driver.

Play with ./script/get_maintainer.pl --file and make sure it picks the
right people for a particular file.

      Andrew
FUJITA Tomonori Oct. 14, 2023, 5:15 a.m. UTC | #7 
On Fri, 13 Oct 2023 20:49:29 +0200
Andrew Lunn <andrew@lunn.ch> wrote:

> On Fri, Oct 13, 2023 at 08:43:21PM +0200, Miguel Ojeda wrote:
>> On Fri, Oct 13, 2023 at 6:17 PM Trevor Gross <tmgross@umich.edu> wrote:
>> >
>> > Thanks for the suggestion Boqun :) I would be happy to be a reviewer
>> > for the rust components of networking.
>> 
>> Thanks a lot Trevor!
>> 
>> > As Tomo mentioned I am not sure there is a good way to indicate this
>> > niche, maybe a new section with two lists? Andrew's call for what
>> > would be best here I suppose.
>> 
>> Yes, maintainers may prefer to split it or not (e.g. "ETHERNET PHY
>> LIBRARY [RUST]"). Then Tomo and you can be there.
>> 
>> That also allows to list only the relevant files in `F:`, to have an
>> extra `L:` for rust-for-linux (in the beginning), a different `S:`
>> level if needed, etc.
> 
> Yes, this seems sensible.
>
> I would also suggest a new entry for the driver.
> 
> Play with ./script/get_maintainer.pl --file and make sure it picks the
> right people for a particular file.

Looks good?

ETHERNET PHY LIBRARY [RUST]
M:  FUJITA Tomonori <fujita.tomonori@gmail.com>
R:  Trevor Gross <tmgross@umich.edu>
L:  netdev@vger.kernel.org
L:  rust-for-linux@vger.kernel.org
S:  Maintained
F:  rust/kernel/net/phy.rs

get_maintainer.pl gives additional information. hopefully, we can move
phy.rs to drivers/net/phy soon.

ubuntu@ip-172-30-47-114:~/git/linux$ ./scripts/get_maintainer.pl --file rust/kernel/net/phy.rs
FUJITA Tomonori <fujita.tomonori@gmail.com> (maintainer:ETHERNET PHY LIBRARY [RUST])
Trevor Gross <tmgross@umich.edu> (reviewer:ETHERNET PHY LIBRARY [RUST])
Miguel Ojeda <ojeda@kernel.org> (supporter:RUST)
Alex Gaynor <alex.gaynor@gmail.com> (supporter:RUST)
Wedson Almeida Filho <wedsonaf@gmail.com> (supporter:RUST)
Boqun Feng <boqun.feng@gmail.com> (reviewer:RUST)
Gary Guo <gary@garyguo.net> (reviewer:RUST)
"Björn Roy Baron" <bjorn3_gh@protonmail.com> (reviewer:RUST)
Benno Lossin <benno.lossin@proton.me> (reviewer:RUST)
Andreas Hindborg <a.hindborg@samsung.com> (reviewer:RUST)
Alice Ryhl <aliceryhl@google.com> (reviewer:RUST)
netdev@vger.kernel.org (open list:ETHERNET PHY LIBRARY [RUST])
rust-for-linux@vger.kernel.org (open list:ETHERNET PHY LIBRARY [RUST])
linux-kernel@vger.kernel.org (open list)
Miguel Ojeda Oct. 14, 2023, 6:18 p.m. UTC | #8 
On Sat, Oct 14, 2023 at 7:15 AM FUJITA Tomonori
<fujita.tomonori@gmail.com> wrote:
>
> Looks good?

Looks good to me!

> get_maintainer.pl gives additional information. hopefully, we can move
> phy.rs to drivers/net/phy soon.

That should be fine for a while, and actually it is probably what we
want initially, i.e. that the Rust subsystem people is contacted.

Later on, when the driver is moved to the right folder, we can also
drop the rust-for-linux@ list too, and we will not be contacted
anymore :)

Cheers,
Miguel
diff mbox series

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index 698ebbd78075..eb51a1d526b7 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -7770,6 +7770,7 @@  F:	net/bridge/
 ETHERNET PHY LIBRARY
 M:	Andrew Lunn <andrew@lunn.ch>
 M:	Heiner Kallweit <hkallweit1@gmail.com>
+M:	FUJITA Tomonori <fujita.tomonori@gmail.com>
 R:	Russell King <linux@armlinux.org.uk>
 L:	netdev@vger.kernel.org
 S:	Maintained
@@ -7799,6 +7800,7 @@  F:	include/trace/events/mdio.h
 F:	include/uapi/linux/mdio.h
 F:	include/uapi/linux/mii.h
 F:	net/core/of_net.c
+F:	rust/kernel/net/phy.rs
 
 EXEC & BINFMT API
 R:	Eric Biederman <ebiederm@xmission.com>