| Message ID | 20231016184428.311983-1-florian.fainelli@broadcom.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] net: phy: bcm7xxx: Add missing 16nm EPHY statistics | expand |
On Mon, Oct 16, 2023 at 11:44:28AM -0700, Florian Fainelli wrote: > The .probe() function would allocate the necessary space and ensure that > the library call sizes the nunber of statistics but the callbacks > necessary to fetch the name and values were not wired up. > > Reported-by: Justin Chen <justin.chen@broadcom.com> > Fixes: 1b89b3dce34c ("net: phy: bcm7xxx: Add EPHY entry for 72165") > Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
On Mon, Oct 16, 2023 at 11:44:28AM -0700, Florian Fainelli wrote: > The .probe() function would allocate the necessary space and ensure that > the library call sizes the nunber of statistics but the callbacks > necessary to fetch the name and values were not wired up. > > Reported-by: Justin Chen <justin.chen@broadcom.com> > Fixes: 1b89b3dce34c ("net: phy: bcm7xxx: Add EPHY entry for 72165") Should the fixes tag be as follows? Fixes: f68d08c437f9 ("net: phy: bcm7xxx: Add EPHY entry for 72165") > Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com> ...
On 10/17/23 12:45, Simon Horman wrote: > On Mon, Oct 16, 2023 at 11:44:28AM -0700, Florian Fainelli wrote: >> The .probe() function would allocate the necessary space and ensure that >> the library call sizes the nunber of statistics but the callbacks >> necessary to fetch the name and values were not wired up. >> >> Reported-by: Justin Chen <justin.chen@broadcom.com> >> Fixes: 1b89b3dce34c ("net: phy: bcm7xxx: Add EPHY entry for 72165") > > Should the fixes tag be as follows? > > Fixes: f68d08c437f9 ("net: phy: bcm7xxx: Add EPHY entry for 72165") Yes it should, it looks like 1b89b3dce34c was from our downstream tree. Let me re-submit with the correct Fixes tag then, thanks Simon!
diff --git a/drivers/net/phy/bcm7xxx.c b/drivers/net/phy/bcm7xxx.c index 8478b081c058..97638ba7ae85 100644 --- a/drivers/net/phy/bcm7xxx.c +++ b/drivers/net/phy/bcm7xxx.c @@ -894,6 +894,9 @@ static int bcm7xxx_28nm_probe(struct phy_device *phydev) .name = _name, \ /* PHY_BASIC_FEATURES */ \ .flags = PHY_IS_INTERNAL, \ + .get_sset_count = bcm_phy_get_sset_count, \ + .get_strings = bcm_phy_get_strings, \ + .get_stats = bcm7xxx_28nm_get_phy_stats, \ .probe = bcm7xxx_28nm_probe, \ .config_init = bcm7xxx_16nm_ephy_config_init, \ .config_aneg = genphy_config_aneg, \
The .probe() function would allocate the necessary space and ensure that the library call sizes the nunber of statistics but the callbacks necessary to fetch the name and values were not wired up. Reported-by: Justin Chen <justin.chen@broadcom.com> Fixes: 1b89b3dce34c ("net: phy: bcm7xxx: Add EPHY entry for 72165") Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com> --- drivers/net/phy/bcm7xxx.c | 3 +++ 1 file changed, 3 insertions(+)