From patchwork Mon Oct 16 18:44:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Fainelli X-Patchwork-Id: 13424027 X-Patchwork-Delegate: kuba@kernel.org Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0FB48339B2 for ; Mon, 16 Oct 2023 18:44:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="Nxz7ekS7" Received: from mail-qv1-xf29.google.com (mail-qv1-xf29.google.com [IPv6:2607:f8b0:4864:20::f29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A2802E8 for ; Mon, 16 Oct 2023 11:44:34 -0700 (PDT) Received: by mail-qv1-xf29.google.com with SMTP id 6a1803df08f44-66d13ac2796so29472656d6.2 for ; Mon, 16 Oct 2023 11:44:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1697481874; x=1698086674; darn=vger.kernel.org; h=mime-version:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=by0+9hZLsAqdLYBnaks0UnHZ0Ucyojox6Mr50t8bjDo=; b=Nxz7ekS7dEV7i7yLkXjor/uipWJ9Rgt5JuVq8FEa0JJ7NQ5U7plQPqTlKUu8QhI+Jf DU58hjFzRXPyS39p1JrE2+A+150a6oIdbUEBnvhOD3E1Buu5Ra8WQhDR5rHYIBmCsCio SVHMsQhnPPsQh28u0z5zS3aTj+oG0ahsvvehs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697481874; x=1698086674; h=mime-version:message-id:date:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=by0+9hZLsAqdLYBnaks0UnHZ0Ucyojox6Mr50t8bjDo=; b=U/sEzM5iVnHh/tjboVAhG84Z16IZZELBXrYG8dd2Sp9ua0DzKilgW9enSF77uqBf0m 2zw29YvbeGaK6icFS5c3mqbuQsL6TWYOQ65IfnAVVTN+x8BWjJSxexcCAvM2aZtbaPYX b6Iep2ZNBV5OPCQJMcBNRPcpMOqCBr/KiVTY8Zmm/V7di1X26R51nuj1vX+MtMo2m9/K 3Zeo/QOY0tXit07gwW9GqX4y0qKhzmJCD77nqDeGKnzKLW2jie8svdzAYSk82DrU0j7W Lj236GByUwq04l+IQCq09s7hI09f5o+cb9ioUB/fUI5+BvGsMi9slJue837XzcpujwkZ Jb6g== X-Gm-Message-State: AOJu0Yw3S7BH2nwJeML3d2lqdlk08nAD6PSYr/bepKJQ783yKL2eBLyG JwioTSEofA71LSqGwbUDmGRC9g== X-Google-Smtp-Source: AGHT+IEoh+/IDmLHtdBame5USf58WGKzs4Wo7KzoEzEl8SejiNFJe1SNEfLLTjDlGVZa1PqZGNsE8Q== X-Received: by 2002:ad4:4ea4:0:b0:66d:6194:77a6 with SMTP id ed4-20020ad44ea4000000b0066d619477a6mr356878qvb.29.1697481873726; Mon, 16 Oct 2023 11:44:33 -0700 (PDT) Received: from fainelli-desktop.igp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id l11-20020ad44bcb000000b0063d5d173a51sm3691132qvw.50.2023.10.16.11.44.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Oct 2023 11:44:32 -0700 (PDT) From: Florian Fainelli To: netdev@vger.kernek.org Cc: Florian Fainelli , Justin Chen , Broadcom internal kernel review list , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org (open list:BROADCOM ETHERNET PHY DRIVERS), linux-kernel@vger.kernel.org (open list) Subject: [PATCH net] net: phy: bcm7xxx: Add missing 16nm EPHY statistics Date: Mon, 16 Oct 2023 11:44:28 -0700 Message-Id: <20231016184428.311983-1-florian.fainelli@broadcom.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MIME_NO_TEXT, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net X-Patchwork-Delegate: kuba@kernel.org The .probe() function would allocate the necessary space and ensure that the library call sizes the nunber of statistics but the callbacks necessary to fetch the name and values were not wired up. Reported-by: Justin Chen Fixes: 1b89b3dce34c ("net: phy: bcm7xxx: Add EPHY entry for 72165") Signed-off-by: Florian Fainelli Reviewed-by: Andrew Lunn --- drivers/net/phy/bcm7xxx.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/phy/bcm7xxx.c b/drivers/net/phy/bcm7xxx.c index 8478b081c058..97638ba7ae85 100644 --- a/drivers/net/phy/bcm7xxx.c +++ b/drivers/net/phy/bcm7xxx.c @@ -894,6 +894,9 @@ static int bcm7xxx_28nm_probe(struct phy_device *phydev) .name = _name, \ /* PHY_BASIC_FEATURES */ \ .flags = PHY_IS_INTERNAL, \ + .get_sset_count = bcm_phy_get_sset_count, \ + .get_strings = bcm_phy_get_strings, \ + .get_stats = bcm7xxx_28nm_get_phy_stats, \ .probe = bcm7xxx_28nm_probe, \ .config_init = bcm7xxx_16nm_ephy_config_init, \ .config_aneg = genphy_config_aneg, \