| Message ID | 20231019182338.832913-1-robh@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | d2ca43f30611ac41bccfa8352c53f5432f0ecbb0 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: xgene: Fix unused xgene_enet_of_match warning for !CONFIG_OF | expand |
Hello: This patch was applied to netdev/net.git (main) by David S. Miller <davem@davemloft.net>: On Thu, 19 Oct 2023 13:23:37 -0500 you wrote: > Commit b0377116decd ("net: ethernet: Use device_get_match_data()") dropped > the unconditional use of xgene_enet_of_match resulting in this warning: > > drivers/net/ethernet/apm/xgene/xgene_enet_main.c:2004:34: warning: unused variable 'xgene_enet_of_match' [-Wunused-const-variable] > > The fix is to drop of_match_ptr() which is not necessary because DT is > always used for this driver (well, it could in theory support ACPI only, > but CONFIG_OF is always enabled for arm64). > > [...] Here is the summary with links: - net: xgene: Fix unused xgene_enet_of_match warning for !CONFIG_OF https://git.kernel.org/netdev/net/c/d2ca43f30611 You are awesome, thank you!
diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c index 56f2b3c229af..44900026d11b 100644 --- a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c +++ b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c @@ -2155,7 +2155,7 @@ static void xgene_enet_shutdown(struct platform_device *pdev) static struct platform_driver xgene_enet_driver = { .driver = { .name = "xgene-enet", - .of_match_table = of_match_ptr(xgene_enet_of_match), + .of_match_table = xgene_enet_of_match, .acpi_match_table = ACPI_PTR(xgene_enet_acpi_match), }, .probe = xgene_enet_probe,
Commit b0377116decd ("net: ethernet: Use device_get_match_data()") dropped the unconditional use of xgene_enet_of_match resulting in this warning: drivers/net/ethernet/apm/xgene/xgene_enet_main.c:2004:34: warning: unused variable 'xgene_enet_of_match' [-Wunused-const-variable] The fix is to drop of_match_ptr() which is not necessary because DT is always used for this driver (well, it could in theory support ACPI only, but CONFIG_OF is always enabled for arm64). Fixes: b0377116decd ("net: ethernet: Use device_get_match_data()") Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202310170627.2Kvf6ZHY-lkp@intel.com/ Signed-off-by: Rob Herring <robh@kernel.org> --- drivers/net/ethernet/apm/xgene/xgene_enet_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)