Message ID | 20231020054024.78295-2-hch@lst.de (mailing list archive) |
---|---|
State | Not Applicable |
Headers | show |
Series | [1/8] dma-direct: add depdenencies to CONFIG_DMA_GLOBAL_POOL | expand |
Context | Check | Description |
---|---|---|
netdev/series_format | warning | Series does not have a cover letter |
netdev/tree_selection | success | Guessed tree name to be net-next |
netdev/fixes_present | success | Fixes tag not required for -next series |
netdev/header_inline | success | No static functions without inline keyword in header files |
netdev/build_32bit | success | Errors and warnings before: 9 this patch: 9 |
netdev/cc_maintainers | success | CCed 4 of 4 maintainers |
netdev/build_clang | success | Errors and warnings before: 9 this patch: 9 |
netdev/verify_signedoff | success | Signed-off-by tag matches author and committer |
netdev/deprecated_api | success | None detected |
netdev/check_selftest | success | No net selftest shell script |
netdev/verify_fixes | success | No Fixes tag |
netdev/build_allmodconfig_warn | success | Errors and warnings before: 9 this patch: 9 |
netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 8 lines checked |
netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
netdev/source_inline | success | Was 0 now: 0 |
s/depdenencies/dependencies/ On Fri, Oct 20, 2023 at 7:40 AM Christoph Hellwig <hch@lst.de> wrote: > CONFIG_DMA_GLOBAL_POOL can't be combined with other DMA coherent > allocators. Add dependencies to Kconfig to document this, and make > kconfig complain about unment dependencies if someone tries. unmet Gr{oetje,eeting}s, Geert
On Fri, Oct 20, 2023 at 09:18:32AM +0200, Geert Uytterhoeven wrote: > s/depdenencies/dependencies/ > > On Fri, Oct 20, 2023 at 7:40 AM Christoph Hellwig <hch@lst.de> wrote: > > CONFIG_DMA_GLOBAL_POOL can't be combined with other DMA coherent > > allocators. Add dependencies to Kconfig to document this, and make > > kconfig complain about unment dependencies if someone tries. > > unmet Thanks, I've fixed this up, and also removed the line selecting ARCH_USE_DMA_ALLOC which snuk back into the second to last patch after the last rebase and applied the whole series to the dma-mapping tree now. The RISC-V dependency fixes still haven't made it to the SOC tree, so you will see dependency warnings in linux-next until that gets fixed.
diff --git a/kernel/dma/Kconfig b/kernel/dma/Kconfig index f488997b071712..4524db877eba36 100644 --- a/kernel/dma/Kconfig +++ b/kernel/dma/Kconfig @@ -135,6 +135,8 @@ config DMA_COHERENT_POOL config DMA_GLOBAL_POOL select DMA_DECLARE_COHERENT + depends on !ARCH_HAS_DMA_SET_UNCACHED + depends on !DMA_DIRECT_REMAP bool config DMA_DIRECT_REMAP