| Message ID | 20231101013351.55902-1-yang.lee@linux.alibaba.com (mailing list archive) |
|---|---|
| State | Awaiting Upstream |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] netfilter: nf_tables: Remove unused variable nft_net | expand |
On Wed, Nov 01, 2023 at 09:33:51AM +0800, Yang Li wrote: > The code that uses nft_net has been removed, and the nft_pernet function > is merely obtaining a reference to shared data through the net pointer. > The content of the net pointer is not modified or changed, so both of > them should be removed. > > silence the warning: > net/netfilter/nft_set_rbtree.c:627:26: warning: variable ‘nft_net’ set but not used > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7103 > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> I think this is for nf-next, rather than net-next (which is closed). But as for the change itself, I also noticed this, and am glad to see it being addressed. Reviewed-by: Simon Horman <horms@kernel.org>
diff --git a/net/netfilter/nft_set_rbtree.c b/net/netfilter/nft_set_rbtree.c index 6f1186abd47b..baa3fea4fe65 100644 --- a/net/netfilter/nft_set_rbtree.c +++ b/net/netfilter/nft_set_rbtree.c @@ -624,14 +624,12 @@ static void nft_rbtree_gc(struct nft_set *set) { struct nft_rbtree *priv = nft_set_priv(set); struct nft_rbtree_elem *rbe, *rbe_end = NULL; - struct nftables_pernet *nft_net; struct rb_node *node, *next; struct nft_trans_gc *gc; struct net *net; set = nft_set_container_of(priv); net = read_pnet(&set->net); - nft_net = nft_pernet(net); gc = nft_trans_gc_alloc(set, 0, GFP_KERNEL); if (!gc)
The code that uses nft_net has been removed, and the nft_pernet function is merely obtaining a reference to shared data through the net pointer. The content of the net pointer is not modified or changed, so both of them should be removed. silence the warning: net/netfilter/nft_set_rbtree.c:627:26: warning: variable ‘nft_net’ set but not used Reported-by: Abaci Robot <abaci@linux.alibaba.com> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7103 Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> --- net/netfilter/nft_set_rbtree.c | 2 -- 1 file changed, 2 deletions(-)