| Message ID | 20231106151124.9175-3-hau@realtek.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | r8169: fix DASH deviceis network lost issue | expand |
On 06.11.2023 16:11, ChunHao Lin wrote: > Device that support DASH may be reseted or powered off during suspend. > So driver needs to handle DASH during system suspend and resume. Or > DASH firmware will influence device behavior and causes network lost. > > Fixes: b646d90053f8 ("r8169: magic.") > Signed-off-by: ChunHao Lin <hau@realtek.com> Also here: cc stable With this: Reviewed-by: Heiner Kallweit <hkallweit1@gmail.com>
> > Device that support DASH may be reseted or powered off during suspend. > > So driver needs to handle DASH during system suspend and resume. Or > > DASH firmware will influence device behavior and causes network lost. > > > > Fixes: b646d90053f8 ("r8169: magic.") > > Signed-off-by: ChunHao Lin <hau@realtek.com> > > Also here: cc stable > With this: > > Reviewed-by: Heiner Kallweit <hkallweit1@gmail.com> Thanks for your advices. I will update the code and submit the patch again.
diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c index 8cbd7c96d9e1..cf32993992bc 100644 --- a/drivers/net/ethernet/realtek/r8169_main.c +++ b/drivers/net/ethernet/realtek/r8169_main.c @@ -4659,10 +4659,16 @@ static void rtl8169_down(struct rtl8169_private *tp) rtl8169_cleanup(tp); rtl_disable_exit_l1(tp); rtl_prepare_power_down(tp); + + if (tp->dash_type != RTL_DASH_NONE) + rtl8168_driver_stop(tp); } static void rtl8169_up(struct rtl8169_private *tp) { + if (tp->dash_type != RTL_DASH_NONE) + rtl8168_driver_start(tp); + pci_set_master(tp->pci_dev); phy_init_hw(tp->phydev); phy_resume(tp->phydev);
Device that support DASH may be reseted or powered off during suspend. So driver needs to handle DASH during system suspend and resume. Or DASH firmware will influence device behavior and causes network lost. Fixes: b646d90053f8 ("r8169: magic.") Signed-off-by: ChunHao Lin <hau@realtek.com> --- drivers/net/ethernet/realtek/r8169_main.c | 6 ++++++ 1 file changed, 6 insertions(+)