| Message ID | 20231128175027.394754-1-andriy.shevchenko@linux.intel.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 4b86d7c64e8f69824b9b2cc0e9b72842ac2d0e62 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next,v1,1/1] net: dsa: sja1105: Use units.h instead of the copy of a definition | expand |
On Tue, Nov 28, 2023 at 07:50:27PM +0200, Andy Shevchenko wrote: > BYTES_PER_KBIT is defined in units.h, use that definition. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Tue, 28 Nov 2023 19:50:27 +0200 you wrote: > BYTES_PER_KBIT is defined in units.h, use that definition. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > drivers/net/dsa/sja1105/sja1105_main.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Here is the summary with links: - [net-next,v1,1/1] net: dsa: sja1105: Use units.h instead of the copy of a definition https://git.kernel.org/netdev/net-next/c/4b86d7c64e8f You are awesome, thank you!
diff --git a/drivers/net/dsa/sja1105/sja1105_main.c b/drivers/net/dsa/sja1105/sja1105_main.c index 74cee39d73df..6646f7fb0f90 100644 --- a/drivers/net/dsa/sja1105/sja1105_main.c +++ b/drivers/net/dsa/sja1105/sja1105_main.c @@ -21,6 +21,8 @@ #include <linux/if_bridge.h> #include <linux/if_ether.h> #include <linux/dsa/8021q.h> +#include <linux/units.h> + #include "sja1105.h" #include "sja1105_tas.h" @@ -2138,7 +2140,6 @@ static void sja1105_bridge_leave(struct dsa_switch *ds, int port, sja1105_bridge_member(ds, port, bridge, false); } -#define BYTES_PER_KBIT (1000LL / 8) /* Port 0 (the uC port) does not have CBS shapers */ #define SJA1110_FIXED_CBS(port, prio) ((((port) - 1) * SJA1105_NUM_TC) + (prio))
BYTES_PER_KBIT is defined in units.h, use that definition. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/net/dsa/sja1105/sja1105_main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)