| Message ID | 20231130055853.19069-1-rdunlap@infradead.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 6c89f49964375c904cea33c0247467873f4daf2c |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [v2] hv_netvsc: rndis_filter needs to select NLS | expand |
Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski <kuba@kernel.org>: On Wed, 29 Nov 2023 21:58:53 -0800 you wrote: > rndis_filter uses utf8s_to_utf16s() which is provided by setting > NLS, so select NLS to fix the build error: > > ERROR: modpost: "utf8s_to_utf16s" [drivers/net/hyperv/hv_netvsc.ko] undefined! > > Fixes: 1ce09e899d28 ("hyperv: Add support for setting MAC from within guests") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Cc: Haiyang Zhang <haiyangz@microsoft.com> > Cc: K. Y. Srinivasan <kys@microsoft.com> > Cc: Wei Liu <wei.liu@kernel.org> > Cc: Dexuan Cui <decui@microsoft.com> > Cc: linux-hyperv@vger.kernel.org > Cc: David S. Miller <davem@davemloft.net> > Cc: Eric Dumazet <edumazet@google.com> > Cc: Jakub Kicinski <kuba@kernel.org> > Cc: Paolo Abeni <pabeni@redhat.com> > Cc: netdev@vger.kernel.org > Reviewed-by: Simon Horman <horms@kernel.org> > Tested-by: Simon Horman <horms@kernel.org> # build-tested > Reviewed-by: Michael Kelley <mikelley@microsoft.com> > > [...] Here is the summary with links: - [v2] hv_netvsc: rndis_filter needs to select NLS https://git.kernel.org/netdev/net/c/6c89f4996437 You are awesome, thank you!
diff -- a/drivers/net/hyperv/Kconfig b/drivers/net/hyperv/Kconfig --- a/drivers/net/hyperv/Kconfig +++ b/drivers/net/hyperv/Kconfig @@ -3,5 +3,6 @@ config HYPERV_NET tristate "Microsoft Hyper-V virtual network driver" depends on HYPERV select UCS2_STRING + select NLS help Select this option to enable the Hyper-V virtual network driver.
rndis_filter uses utf8s_to_utf16s() which is provided by setting NLS, so select NLS to fix the build error: ERROR: modpost: "utf8s_to_utf16s" [drivers/net/hyperv/hv_netvsc.ko] undefined! Fixes: 1ce09e899d28 ("hyperv: Add support for setting MAC from within guests") Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Cc: Haiyang Zhang <haiyangz@microsoft.com> Cc: K. Y. Srinivasan <kys@microsoft.com> Cc: Wei Liu <wei.liu@kernel.org> Cc: Dexuan Cui <decui@microsoft.com> Cc: linux-hyperv@vger.kernel.org Cc: David S. Miller <davem@davemloft.net> Cc: Eric Dumazet <edumazet@google.com> Cc: Jakub Kicinski <kuba@kernel.org> Cc: Paolo Abeni <pabeni@redhat.com> Cc: netdev@vger.kernel.org Reviewed-by: Simon Horman <horms@kernel.org> Tested-by: Simon Horman <horms@kernel.org> # build-tested Reviewed-by: Michael Kelley <mikelley@microsoft.com> --- v2: correct Subject prefix (Michael) drivers/net/hyperv/Kconfig | 1 + 1 file changed, 1 insertion(+)