| Message ID | 20231204163528.1797565-5-ioana.ciornei@nxp.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | dpaa2-switch: small improvements | expand |
On Mon, 4 Dec 2023 18:35:24 +0200 Ioana Ciornei wrote: > Add the ENDPOINT_CHANGED irq to the irq_mask since it was omitted in the > blamed commit. Any user-visible impact? What's the observable problem?
On Tue, Dec 05, 2023 at 07:58:19PM -0800, Jakub Kicinski wrote: > On Mon, 4 Dec 2023 18:35:24 +0200 Ioana Ciornei wrote: > > Add the ENDPOINT_CHANGED irq to the irq_mask since it was omitted in the > > blamed commit. > > Any user-visible impact? What's the observable problem? No user-visible impact but that is only because the firmware sets both events anytime a switch interface is connected to a MAC. We shouldn't rely on this behavior since it's not documented. And this is why I didn't catch the problem when I initially sent the patch.
diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-switch.c b/drivers/net/ethernet/freescale/dpaa2/dpaa2-switch.c index 654dd10df307..e91ade7c7c93 100644 --- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-switch.c +++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-switch.c @@ -1550,9 +1550,9 @@ static irqreturn_t dpaa2_switch_irq0_handler_thread(int irq_num, void *arg) static int dpaa2_switch_setup_irqs(struct fsl_mc_device *sw_dev) { + u32 mask = DPSW_IRQ_EVENT_LINK_CHANGED | DPSW_IRQ_EVENT_ENDPOINT_CHANGED; struct device *dev = &sw_dev->dev; struct ethsw_core *ethsw = dev_get_drvdata(dev); - u32 mask = DPSW_IRQ_EVENT_LINK_CHANGED; struct fsl_mc_device_irq *irq; int err;
Add the ENDPOINT_CHANGED irq to the irq_mask since it was omitted in the blamed commit. Fixes: 84cba72956fd ("dpaa2-switch: integrate the MAC endpoint support") Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com> --- drivers/net/ethernet/freescale/dpaa2/dpaa2-switch.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)