| Message ID | 20231208055646.2602363-1-srasheed@marvell.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 284f717622417cb267e344a9174f8e5698d1e3c1 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net,v3] octeon_ep: explicitly test for firmware ready value | expand |
On Thu, Dec 07, 2023 at 09:56:46PM -0800, Shinas Rasheed wrote: > The firmware ready value is 1, and get firmware ready status > function should explicitly test for that value. The firmware > ready value read will be 2 after driver load, and on unbind > till firmware rewrites the firmware ready back to 0, the value > seen by driver will be 2, which should be regarded as not ready. > > Fixes: 10c073e40469 ("octeon_ep: defer probe if firmware not ready") > Signed-off-by: Shinas Rasheed <srasheed@marvell.com> Reviewed-by: Simon Horman <horms@kernel.org>
Hello: This patch was applied to netdev/net.git (main) by David S. Miller <davem@davemloft.net>: On Thu, 7 Dec 2023 21:56:46 -0800 you wrote: > The firmware ready value is 1, and get firmware ready status > function should explicitly test for that value. The firmware > ready value read will be 2 after driver load, and on unbind > till firmware rewrites the firmware ready back to 0, the value > seen by driver will be 2, which should be regarded as not ready. > > Fixes: 10c073e40469 ("octeon_ep: defer probe if firmware not ready") > Signed-off-by: Shinas Rasheed <srasheed@marvell.com> > > [...] Here is the summary with links: - [net,v3] octeon_ep: explicitly test for firmware ready value https://git.kernel.org/netdev/net/c/284f71762241 You are awesome, thank you!
diff --git a/drivers/net/ethernet/marvell/octeon_ep/octep_main.c b/drivers/net/ethernet/marvell/octeon_ep/octep_main.c index 552970c7dec0..b8ae269f6f97 100644 --- a/drivers/net/ethernet/marvell/octeon_ep/octep_main.c +++ b/drivers/net/ethernet/marvell/octeon_ep/octep_main.c @@ -1258,7 +1258,8 @@ static bool get_fw_ready_status(struct pci_dev *pdev) pci_read_config_byte(pdev, (pos + 8), &status); dev_info(&pdev->dev, "Firmware ready status = %u\n", status); - return status; +#define FW_STATUS_READY 1ULL + return status == FW_STATUS_READY; } return false; }
The firmware ready value is 1, and get firmware ready status function should explicitly test for that value. The firmware ready value read will be 2 after driver load, and on unbind till firmware rewrites the firmware ready back to 0, the value seen by driver will be 2, which should be regarded as not ready. Fixes: 10c073e40469 ("octeon_ep: defer probe if firmware not ready") Signed-off-by: Shinas Rasheed <srasheed@marvell.com> --- V3: - Removed unnecessary parenthesis around boolean return. V2: https://lore.kernel.org/all/20231207074936.2597889-1-srasheed@marvell.com/ - Fixed redundant logic V1: https://lore.kernel.org/all/20231206063549.2590305-1-srasheed@marvell.com/ drivers/net/ethernet/marvell/octeon_ep/octep_main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)