| Message ID | 20231211164039.83034-3-donald.hunter@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | tools/net/ynl: Add 'sub-message' support to ynl | expand |
On Mon, 11 Dec 2023 16:40:30 +0000 Donald Hunter wrote: > The index of netlink specs was being generated unsorted. Sort the output > before generating the index entries. > > Signed-off-by: Donald Hunter <donald.hunter@gmail.com> Reviewed-by: Jakub Kicinski <kuba@kernel.org> Please do CC Breno on tools/net/ynl/ynl-gen-rst.py changes. https://lore.kernel.org/all/20231211164039.83034-3-donald.hunter@gmail.com/
Jakub Kicinski <kuba@kernel.org> writes: > On Mon, 11 Dec 2023 16:40:30 +0000 Donald Hunter wrote: >> The index of netlink specs was being generated unsorted. Sort the output >> before generating the index entries. >> >> Signed-off-by: Donald Hunter <donald.hunter@gmail.com> > > Reviewed-by: Jakub Kicinski <kuba@kernel.org> > > Please do CC Breno on tools/net/ynl/ynl-gen-rst.py changes. > https://lore.kernel.org/all/20231211164039.83034-3-donald.hunter@gmail.com/ Ack, will do. Is there a streamlined way to apply output from get_maintainer.pl to individual patches in a series, or do I just add specific names by hand?
On Tue, 12 Dec 2023 11:30:11 +0000 Donald Hunter wrote: > Jakub Kicinski <kuba@kernel.org> writes: > > On Mon, 11 Dec 2023 16:40:30 +0000 Donald Hunter wrote: > >> The index of netlink specs was being generated unsorted. Sort the output > >> before generating the index entries. > >> > >> Signed-off-by: Donald Hunter <donald.hunter@gmail.com> > > > > Reviewed-by: Jakub Kicinski <kuba@kernel.org> > > > > Please do CC Breno on tools/net/ynl/ynl-gen-rst.py changes. > > https://lore.kernel.org/all/20231211164039.83034-3-donald.hunter@gmail.com/ > > Ack, will do. > > Is there a streamlined way to apply output from get_maintainer.pl to > individual patches in a series, or do I just add specific names by hand? Some people have a CC command as a git send-email hook. Others have scripts to insert CCs into the commits themselves. I think there was an attempt to add a relevant code to scripts/ but I think it was rejected. You gotta look around :(
On Mon, Dec 11, 2023 at 03:30:00PM -0800, Jakub Kicinski wrote: > On Mon, 11 Dec 2023 16:40:30 +0000 Donald Hunter wrote: > > The index of netlink specs was being generated unsorted. Sort the output > > before generating the index entries. > > > > Signed-off-by: Donald Hunter <donald.hunter@gmail.com> > > Reviewed-by: Jakub Kicinski <kuba@kernel.org> Reviewed-by: Breno Leitao <leitao@debian.org>
diff --git a/tools/net/ynl/ynl-gen-rst.py b/tools/net/ynl/ynl-gen-rst.py index a1d046c60512..f0bb2f4dc4fa 100755 --- a/tools/net/ynl/ynl-gen-rst.py +++ b/tools/net/ynl/ynl-gen-rst.py @@ -354,7 +354,7 @@ def generate_main_index_rst(output: str) -> None: index_dir = os.path.dirname(output) logging.debug("Looking for .rst files in %s", index_dir) - for filename in os.listdir(index_dir): + for filename in sorted(os.listdir(index_dir)): if not filename.endswith(".rst") or filename == "index.rst": continue lines.append(f" {filename.replace('.rst', '')}\n")
The index of netlink specs was being generated unsorted. Sort the output before generating the index entries. Signed-off-by: Donald Hunter <donald.hunter@gmail.com> --- tools/net/ynl/ynl-gen-rst.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)