| Message ID | 20231213043650.12672-1-rdunlap@infradead.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | fcb29877f7e18a1f27d7d6871f5f7bb6aaade575 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | page_pool: fix typos and punctuation | expand |
On 13/12/2023 05.36, Randy Dunlap wrote: > Correct spelling (s/and/any) and a run-on sentence. > Spell out "multi". > > Signed-off-by: Randy Dunlap<rdunlap@infradead.org> > Cc: Jesper Dangaard Brouer<hawk@kernel.org> > Cc: Ilias Apalodimas<ilias.apalodimas@linaro.org> > Cc: "David S. Miller"<davem@davemloft.net> > Cc: Eric Dumazet<edumazet@google.com> > Cc: Jakub Kicinski<kuba@kernel.org> > Cc: Paolo Abeni<pabeni@redhat.com> > --- > include/net/page_pool/helpers.h | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) Acked-by: Jesper Dangaard Brouer <hawk@kernel.org>
Hi Randy, Thanks for cleaning this up On Wed, 13 Dec 2023 at 06:36, Randy Dunlap <rdunlap@infradead.org> wrote: > > Correct spelling (s/and/any) and a run-on sentence. > Spell out "multi". > > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Cc: Jesper Dangaard Brouer <hawk@kernel.org> > Cc: Ilias Apalodimas <ilias.apalodimas@linaro.org> > Cc: "David S. Miller" <davem@davemloft.net> > Cc: Eric Dumazet <edumazet@google.com> > Cc: Jakub Kicinski <kuba@kernel.org> > Cc: Paolo Abeni <pabeni@redhat.com> > --- > include/net/page_pool/helpers.h | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff -- a/include/net/page_pool/helpers.h b/include/net/page_pool/helpers.h > --- a/include/net/page_pool/helpers.h > +++ b/include/net/page_pool/helpers.h > @@ -11,7 +11,7 @@ > * The page_pool allocator is optimized for recycling page or page fragment used > * by skb packet and xdp frame. > * > - * Basic use involves replacing and alloc_pages() calls with page_pool_alloc(), > + * Basic use involves replacing any alloc_pages() calls with page_pool_alloc(), > * which allocate memory with or without page splitting depending on the > * requested memory size. > * > @@ -37,15 +37,15 @@ > * attach the page_pool object to a page_pool-aware object like skbs marked with > * skb_mark_for_recycle(). > * > - * page_pool_put_page() may be called multi times on the same page if a page is > - * split into multi fragments. For the last fragment, it will either recycle the > - * page, or in case of page->_refcount > 1, it will release the DMA mapping and > - * in-flight state accounting. > + * page_pool_put_page() may be called multiple times on the same page if a page > + * is split into multiple fragments. For the last fragment, it will either > + * recycle the page, or in case of page->_refcount > 1, it will release the DMA > + * mapping and in-flight state accounting. > * > * dma_sync_single_range_for_device() is only called for the last fragment when > * page_pool is created with PP_FLAG_DMA_SYNC_DEV flag, so it depends on the > * last freed fragment to do the sync_for_device operation for all fragments in > - * the same page when a page is split, the API user must setup pool->p.max_len > + * the same page when a page is split. The API user must setup pool->p.max_len > * and pool->p.offset correctly and ensure that page_pool_put_page() is called > * with dma_sync_size being -1 for fragment API. > */ Acked-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Tue, 12 Dec 2023 20:36:50 -0800 you wrote: > Correct spelling (s/and/any) and a run-on sentence. > Spell out "multi". > > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Cc: Jesper Dangaard Brouer <hawk@kernel.org> > Cc: Ilias Apalodimas <ilias.apalodimas@linaro.org> > Cc: "David S. Miller" <davem@davemloft.net> > Cc: Eric Dumazet <edumazet@google.com> > Cc: Jakub Kicinski <kuba@kernel.org> > Cc: Paolo Abeni <pabeni@redhat.com> > > [...] Here is the summary with links: - page_pool: fix typos and punctuation https://git.kernel.org/netdev/net-next/c/fcb29877f7e1 You are awesome, thank you!
diff -- a/include/net/page_pool/helpers.h b/include/net/page_pool/helpers.h --- a/include/net/page_pool/helpers.h +++ b/include/net/page_pool/helpers.h @@ -11,7 +11,7 @@ * The page_pool allocator is optimized for recycling page or page fragment used * by skb packet and xdp frame. * - * Basic use involves replacing and alloc_pages() calls with page_pool_alloc(), + * Basic use involves replacing any alloc_pages() calls with page_pool_alloc(), * which allocate memory with or without page splitting depending on the * requested memory size. * @@ -37,15 +37,15 @@ * attach the page_pool object to a page_pool-aware object like skbs marked with * skb_mark_for_recycle(). * - * page_pool_put_page() may be called multi times on the same page if a page is - * split into multi fragments. For the last fragment, it will either recycle the - * page, or in case of page->_refcount > 1, it will release the DMA mapping and - * in-flight state accounting. + * page_pool_put_page() may be called multiple times on the same page if a page + * is split into multiple fragments. For the last fragment, it will either + * recycle the page, or in case of page->_refcount > 1, it will release the DMA + * mapping and in-flight state accounting. * * dma_sync_single_range_for_device() is only called for the last fragment when * page_pool is created with PP_FLAG_DMA_SYNC_DEV flag, so it depends on the * last freed fragment to do the sync_for_device operation for all fragments in - * the same page when a page is split, the API user must setup pool->p.max_len + * the same page when a page is split. The API user must setup pool->p.max_len * and pool->p.offset correctly and ensure that page_pool_put_page() is called * with dma_sync_size being -1 for fragment API. */
Correct spelling (s/and/any) and a run-on sentence. Spell out "multi". Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Cc: Jesper Dangaard Brouer <hawk@kernel.org> Cc: Ilias Apalodimas <ilias.apalodimas@linaro.org> Cc: "David S. Miller" <davem@davemloft.net> Cc: Eric Dumazet <edumazet@google.com> Cc: Jakub Kicinski <kuba@kernel.org> Cc: Paolo Abeni <pabeni@redhat.com> --- include/net/page_pool/helpers.h | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)