diff mbox series

[next] selftests/net: Fix various spelling mistakes in TCP-AO tests

Message ID 20231218133022.321069-1-colin.i.king@gmail.com (mailing list archive)
State Accepted
Commit 67f440c05dd2fca9f26057e713d8618e23c4e021
Delegated to: Netdev Maintainers
Headers show
Series [next] selftests/net: Fix various spelling mistakes in TCP-AO tests | expand

Checks

Context Check Description
netdev/series_format warning Single patches do not need cover letters; Target tree name not specified in the subject
netdev/tree_selection success Guessed tree name to be net-next
netdev/ynl success Generated files up to date; no warnings/errors; no diff in generated;
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 8 this patch: 8
netdev/cc_maintainers warning 1 maintainers not CCed: rdunlap@infradead.org
netdev/build_clang fail Errors and warnings before: 12 this patch: 12
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 8 this patch: 8
netdev/checkpatch warning WARNING: line length of 93 exceeds 80 columns
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0

Commit Message

Colin Ian King Dec. 18, 2023, 1:30 p.m. UTC 
There are a handful of spelling mistakes in test messages in the
TCP-AIO selftests. Fix these.

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
 tools/testing/selftests/net/tcp_ao/connect-deny.c      | 2 +-
 tools/testing/selftests/net/tcp_ao/lib/proc.c          | 4 ++--
 tools/testing/selftests/net/tcp_ao/setsockopt-closed.c | 2 +-
 tools/testing/selftests/net/tcp_ao/unsigned-md5.c      | 2 +-
 4 files changed, 5 insertions(+), 5 deletions(-)

Comments

Dmitry Safonov Dec. 18, 2023, 5:50 p.m. UTC | #1 
On 12/18/23 13:30, Colin Ian King wrote:
> There are a handful of spelling mistakes in test messages in the
> TCP-AIO selftests. Fix these.
> 
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>

Thank you, Colin.

The patch looks good to me, my grammar and typos - not so much :-)

Reviewed-by: Dmitry Safonov <dima@arista.com>

> ---
>  tools/testing/selftests/net/tcp_ao/connect-deny.c      | 2 +-
>  tools/testing/selftests/net/tcp_ao/lib/proc.c          | 4 ++--
>  tools/testing/selftests/net/tcp_ao/setsockopt-closed.c | 2 +-
>  tools/testing/selftests/net/tcp_ao/unsigned-md5.c      | 2 +-
>  4 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/tools/testing/selftests/net/tcp_ao/connect-deny.c b/tools/testing/selftests/net/tcp_ao/connect-deny.c
> index 1ca78040d8b7..185a2f6e5ff3 100644
> --- a/tools/testing/selftests/net/tcp_ao/connect-deny.c
> +++ b/tools/testing/selftests/net/tcp_ao/connect-deny.c
> @@ -55,7 +55,7 @@ static void try_accept(const char *tst_name, unsigned int port, const char *pwd,
>  	err = test_wait_fd(lsk, timeout, 0);
>  	if (err == -ETIMEDOUT) {
>  		if (!fault(TIMEOUT))
> -			test_fail("timeouted for accept()");
> +			test_fail("timed out for accept()");
>  	} else if (err < 0) {
>  		test_error("test_wait_fd()");
>  	} else {
> diff --git a/tools/testing/selftests/net/tcp_ao/lib/proc.c b/tools/testing/selftests/net/tcp_ao/lib/proc.c
> index 2322f4d4676d..2fb6dd8adba6 100644
> --- a/tools/testing/selftests/net/tcp_ao/lib/proc.c
> +++ b/tools/testing/selftests/net/tcp_ao/lib/proc.c
> @@ -227,7 +227,7 @@ void netstat_print_diff(struct netstat *nsa, struct netstat *nsb)
>  		}
>  
>  		if (nsb->counters_nr < nsa->counters_nr)
> -			test_error("Unexpected: some counters dissapeared!");
> +			test_error("Unexpected: some counters disappeared!");
>  
>  		for (j = 0, i = 0; i < nsb->counters_nr; i++) {
>  			if (strcmp(nsb->counters[i].name, nsa->counters[j].name)) {
> @@ -244,7 +244,7 @@ void netstat_print_diff(struct netstat *nsa, struct netstat *nsb)
>  			j++;
>  		}
>  		if (j != nsa->counters_nr)
> -			test_error("Unexpected: some counters dissapeared!");
> +			test_error("Unexpected: some counters disappeared!");
>  
>  		nsb = nsb->next;
>  		nsa = nsa->next;
> diff --git a/tools/testing/selftests/net/tcp_ao/setsockopt-closed.c b/tools/testing/selftests/net/tcp_ao/setsockopt-closed.c
> index 7e4601b3f6a3..a329f42f40ce 100644
> --- a/tools/testing/selftests/net/tcp_ao/setsockopt-closed.c
> +++ b/tools/testing/selftests/net/tcp_ao/setsockopt-closed.c
> @@ -427,7 +427,7 @@ static void test_einval_del_key(void)
>  
>  	sk = prepare_defs(TCP_AO_DEL_KEY, &del);
>  	del.set_current = 1;
> -	setsockopt_checked(sk, TCP_AO_DEL_KEY, &del, ENOENT, "set non-exising current key");
> +	setsockopt_checked(sk, TCP_AO_DEL_KEY, &del, ENOENT, "set non-existing current key");
>  
>  	sk = prepare_defs(TCP_AO_DEL_KEY, &del);
>  	del.set_rnext = 1;
> diff --git a/tools/testing/selftests/net/tcp_ao/unsigned-md5.c b/tools/testing/selftests/net/tcp_ao/unsigned-md5.c
> index 7cffde02d2be..14addfd46468 100644
> --- a/tools/testing/selftests/net/tcp_ao/unsigned-md5.c
> +++ b/tools/testing/selftests/net/tcp_ao/unsigned-md5.c
> @@ -72,7 +72,7 @@ static void try_accept(const char *tst_name, unsigned int port,
>  	err = test_wait_fd(lsk, timeout, 0);
>  	if (err == -ETIMEDOUT) {
>  		if (!fault(TIMEOUT))
> -			test_fail("timeouted for accept()");
> +			test_fail("timed out for accept()");
>  	} else if (err < 0) {
>  		test_error("test_wait_fd()");
>  	} else {

Thanks,
            Dmitry
Randy Dunlap Dec. 18, 2023, 7:24 p.m. UTC | #2 
On 12/18/23 05:30, Colin Ian King wrote:
> There are a handful of spelling mistakes in test messages in the
> TCP-AIO selftests. Fix these.
> 
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>

Reviewed-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.

> ---
>  tools/testing/selftests/net/tcp_ao/connect-deny.c      | 2 +-
>  tools/testing/selftests/net/tcp_ao/lib/proc.c          | 4 ++--
>  tools/testing/selftests/net/tcp_ao/setsockopt-closed.c | 2 +-
>  tools/testing/selftests/net/tcp_ao/unsigned-md5.c      | 2 +-
>  4 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/tools/testing/selftests/net/tcp_ao/connect-deny.c b/tools/testing/selftests/net/tcp_ao/connect-deny.c
> index 1ca78040d8b7..185a2f6e5ff3 100644
> --- a/tools/testing/selftests/net/tcp_ao/connect-deny.c
> +++ b/tools/testing/selftests/net/tcp_ao/connect-deny.c
> @@ -55,7 +55,7 @@ static void try_accept(const char *tst_name, unsigned int port, const char *pwd,
>  	err = test_wait_fd(lsk, timeout, 0);
>  	if (err == -ETIMEDOUT) {
>  		if (!fault(TIMEOUT))
> -			test_fail("timeouted for accept()");
> +			test_fail("timed out for accept()");
>  	} else if (err < 0) {
>  		test_error("test_wait_fd()");
>  	} else {
> diff --git a/tools/testing/selftests/net/tcp_ao/lib/proc.c b/tools/testing/selftests/net/tcp_ao/lib/proc.c
> index 2322f4d4676d..2fb6dd8adba6 100644
> --- a/tools/testing/selftests/net/tcp_ao/lib/proc.c
> +++ b/tools/testing/selftests/net/tcp_ao/lib/proc.c
> @@ -227,7 +227,7 @@ void netstat_print_diff(struct netstat *nsa, struct netstat *nsb)
>  		}
>  
>  		if (nsb->counters_nr < nsa->counters_nr)
> -			test_error("Unexpected: some counters dissapeared!");
> +			test_error("Unexpected: some counters disappeared!");
>  
>  		for (j = 0, i = 0; i < nsb->counters_nr; i++) {
>  			if (strcmp(nsb->counters[i].name, nsa->counters[j].name)) {
> @@ -244,7 +244,7 @@ void netstat_print_diff(struct netstat *nsa, struct netstat *nsb)
>  			j++;
>  		}
>  		if (j != nsa->counters_nr)
> -			test_error("Unexpected: some counters dissapeared!");
> +			test_error("Unexpected: some counters disappeared!");
>  
>  		nsb = nsb->next;
>  		nsa = nsa->next;
> diff --git a/tools/testing/selftests/net/tcp_ao/setsockopt-closed.c b/tools/testing/selftests/net/tcp_ao/setsockopt-closed.c
> index 7e4601b3f6a3..a329f42f40ce 100644
> --- a/tools/testing/selftests/net/tcp_ao/setsockopt-closed.c
> +++ b/tools/testing/selftests/net/tcp_ao/setsockopt-closed.c
> @@ -427,7 +427,7 @@ static void test_einval_del_key(void)
>  
>  	sk = prepare_defs(TCP_AO_DEL_KEY, &del);
>  	del.set_current = 1;
> -	setsockopt_checked(sk, TCP_AO_DEL_KEY, &del, ENOENT, "set non-exising current key");
> +	setsockopt_checked(sk, TCP_AO_DEL_KEY, &del, ENOENT, "set non-existing current key");
>  
>  	sk = prepare_defs(TCP_AO_DEL_KEY, &del);
>  	del.set_rnext = 1;
> diff --git a/tools/testing/selftests/net/tcp_ao/unsigned-md5.c b/tools/testing/selftests/net/tcp_ao/unsigned-md5.c
> index 7cffde02d2be..14addfd46468 100644
> --- a/tools/testing/selftests/net/tcp_ao/unsigned-md5.c
> +++ b/tools/testing/selftests/net/tcp_ao/unsigned-md5.c
> @@ -72,7 +72,7 @@ static void try_accept(const char *tst_name, unsigned int port,
>  	err = test_wait_fd(lsk, timeout, 0);
>  	if (err == -ETIMEDOUT) {
>  		if (!fault(TIMEOUT))
> -			test_fail("timeouted for accept()");
> +			test_fail("timed out for accept()");
>  	} else if (err < 0) {
>  		test_error("test_wait_fd()");
>  	} else {
patchwork-bot+netdevbpf@kernel.org Dec. 22, 2023, 10:20 p.m. UTC | #3 
Hello:

This patch was applied to netdev/net-next.git (main)
by David S. Miller <davem@davemloft.net>:

On Mon, 18 Dec 2023 13:30:22 +0000 you wrote:
> There are a handful of spelling mistakes in test messages in the
> TCP-AIO selftests. Fix these.
> 
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
>  tools/testing/selftests/net/tcp_ao/connect-deny.c      | 2 +-
>  tools/testing/selftests/net/tcp_ao/lib/proc.c          | 4 ++--
>  tools/testing/selftests/net/tcp_ao/setsockopt-closed.c | 2 +-
>  tools/testing/selftests/net/tcp_ao/unsigned-md5.c      | 2 +-
>  4 files changed, 5 insertions(+), 5 deletions(-)

Here is the summary with links:
  - [next] selftests/net: Fix various spelling mistakes in TCP-AO tests
    https://git.kernel.org/netdev/net-next/c/67f440c05dd2

You are awesome, thank you!
diff mbox series

Patch

diff --git a/tools/testing/selftests/net/tcp_ao/connect-deny.c b/tools/testing/selftests/net/tcp_ao/connect-deny.c
index 1ca78040d8b7..185a2f6e5ff3 100644
--- a/tools/testing/selftests/net/tcp_ao/connect-deny.c
+++ b/tools/testing/selftests/net/tcp_ao/connect-deny.c
@@ -55,7 +55,7 @@  static void try_accept(const char *tst_name, unsigned int port, const char *pwd,
 	err = test_wait_fd(lsk, timeout, 0);
 	if (err == -ETIMEDOUT) {
 		if (!fault(TIMEOUT))
-			test_fail("timeouted for accept()");
+			test_fail("timed out for accept()");
 	} else if (err < 0) {
 		test_error("test_wait_fd()");
 	} else {
diff --git a/tools/testing/selftests/net/tcp_ao/lib/proc.c b/tools/testing/selftests/net/tcp_ao/lib/proc.c
index 2322f4d4676d..2fb6dd8adba6 100644
--- a/tools/testing/selftests/net/tcp_ao/lib/proc.c
+++ b/tools/testing/selftests/net/tcp_ao/lib/proc.c
@@ -227,7 +227,7 @@  void netstat_print_diff(struct netstat *nsa, struct netstat *nsb)
 		}
 
 		if (nsb->counters_nr < nsa->counters_nr)
-			test_error("Unexpected: some counters dissapeared!");
+			test_error("Unexpected: some counters disappeared!");
 
 		for (j = 0, i = 0; i < nsb->counters_nr; i++) {
 			if (strcmp(nsb->counters[i].name, nsa->counters[j].name)) {
@@ -244,7 +244,7 @@  void netstat_print_diff(struct netstat *nsa, struct netstat *nsb)
 			j++;
 		}
 		if (j != nsa->counters_nr)
-			test_error("Unexpected: some counters dissapeared!");
+			test_error("Unexpected: some counters disappeared!");
 
 		nsb = nsb->next;
 		nsa = nsa->next;
diff --git a/tools/testing/selftests/net/tcp_ao/setsockopt-closed.c b/tools/testing/selftests/net/tcp_ao/setsockopt-closed.c
index 7e4601b3f6a3..a329f42f40ce 100644
--- a/tools/testing/selftests/net/tcp_ao/setsockopt-closed.c
+++ b/tools/testing/selftests/net/tcp_ao/setsockopt-closed.c
@@ -427,7 +427,7 @@  static void test_einval_del_key(void)
 
 	sk = prepare_defs(TCP_AO_DEL_KEY, &del);
 	del.set_current = 1;
-	setsockopt_checked(sk, TCP_AO_DEL_KEY, &del, ENOENT, "set non-exising current key");
+	setsockopt_checked(sk, TCP_AO_DEL_KEY, &del, ENOENT, "set non-existing current key");
 
 	sk = prepare_defs(TCP_AO_DEL_KEY, &del);
 	del.set_rnext = 1;
diff --git a/tools/testing/selftests/net/tcp_ao/unsigned-md5.c b/tools/testing/selftests/net/tcp_ao/unsigned-md5.c
index 7cffde02d2be..14addfd46468 100644
--- a/tools/testing/selftests/net/tcp_ao/unsigned-md5.c
+++ b/tools/testing/selftests/net/tcp_ao/unsigned-md5.c
@@ -72,7 +72,7 @@  static void try_accept(const char *tst_name, unsigned int port,
 	err = test_wait_fd(lsk, timeout, 0);
 	if (err == -ETIMEDOUT) {
 		if (!fault(TIMEOUT))
-			test_fail("timeouted for accept()");
+			test_fail("timed out for accept()");
 	} else if (err < 0) {
 		test_error("test_wait_fd()");
 	} else {