diff mbox series

[iproute2] ip: merge duplicate if clauses

Message ID 20240104003127.23877-2-stephen@networkplumber.org (mailing list archive)
State Accepted
Commit 43a0e300dd8633a8e3edf99000bc039262ea2ec6
Delegated to: Stephen Hemminger
Headers show
Series [iproute2] ip: merge duplicate if clauses | expand

Checks

Context Check Description
netdev/tree_selection success Not a local patch

Commit Message

Stephen Hemminger Jan. 4, 2024, 12:31 a.m. UTC
The code that handles brief option had two exactly matching
if (filter == AF_PACKET) clauses; merge them

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 ip/ipaddress.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Petr Machata Jan. 4, 2024, 11:18 a.m. UTC | #1
Stephen Hemminger <stephen@networkplumber.org> writes:

> The code that handles brief option had two exactly matching
> if (filter == AF_PACKET) clauses; merge them
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

Reviewed-by: Petr Machata <me@pmachata.org>
patchwork-bot+netdevbpf@kernel.org Jan. 7, 2024, 5:30 p.m. UTC | #2
Hello:

This patch was applied to iproute2/iproute2.git (main)
by Stephen Hemminger <stephen@networkplumber.org>:

On Wed,  3 Jan 2024 16:31:28 -0800 you wrote:
> The code that handles brief option had two exactly matching
> if (filter == AF_PACKET) clauses; merge them
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>  ip/ipaddress.c | 2 --
>  1 file changed, 2 deletions(-)

Here is the summary with links:
  - [iproute2] ip: merge duplicate if clauses
    https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/commit/?id=43a0e300dd86

You are awesome, thank you!
diff mbox series

Patch

diff --git a/ip/ipaddress.c b/ip/ipaddress.c
index 8197709d172e..e536912fc603 100644
--- a/ip/ipaddress.c
+++ b/ip/ipaddress.c
@@ -929,9 +929,7 @@  static int print_linkinfo_brief(FILE *fp, const char *name,
 						   ifi->ifi_type,
 						   b1, sizeof(b1)));
 		}
-	}
 
-	if (filter.family == AF_PACKET) {
 		print_link_flags(fp, ifi->ifi_flags, m_flag);
 		print_string(PRINT_FP, NULL, "%s", "\n");
 	}