From patchwork Thu Jan 4 00:59:24 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Chan X-Patchwork-Id: 13510704 X-Patchwork-Delegate: kuba@kernel.org Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1AAAA4C92 for ; Thu, 4 Jan 2024 00:59:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="gcBNRMh8" Received: by mail-pg1-f181.google.com with SMTP id 41be03b00d2f7-5cd8667c59eso14091a12.2 for ; Wed, 03 Jan 2024 16:59:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1704329979; x=1704934779; darn=vger.kernel.org; h=mime-version:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=T6FIJx3lLDIiIawObHHm0348y41AleGw4w6oe1Cnk6c=; b=gcBNRMh8AzOyVwQKzS+NseUNA0J5SEF2aYN+lnPm/HvvxjZ3U+RwM7aEb6y3vVYUBL UydPKptcrdmyBbYAVMRPyRg8YLLTmh8JPuwDcndIQ+mhx4bVmWc4012hFx/OiG//wgnX MRwFysttDALK4GhhQ9jJuinVLjuQ1Ala0YBls= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704329979; x=1704934779; h=mime-version:message-id:date:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=T6FIJx3lLDIiIawObHHm0348y41AleGw4w6oe1Cnk6c=; b=hkTwJ9W4mYj5K0+HpZ97ylaMkiG7TRGaW2ZTxS6bhe/bliYxRdbdYTYRzu3FcD6yTC rgsLlRQAiVifDgZZsH2LQpOg9sQ0QAkzZcsIFbkQBR+hd0HiFXMi2/B7jY2qjPRwBHJO 3m06w5MO+1vB6XncFX/JP8ZWjxmnB01a0uxZvBiKJD0Ge0Xz59vy9GGnwjOM85tm7H5U RLfI2cTV62hzMA7oLlDMCQpszy6vV23fWvhZCS8gCDkM5cN5ZoSzOdnIJvQwyGf/YfSX cm4nFSI8dsm14GmRo8tn30PDhOT00cn0Y0u/aF9PmO0yKGm/R4gsmPObFGva0PejYpG+ R8gg== X-Gm-Message-State: AOJu0YxxEfWNOgkiCg44mgK6H8cAUAlYO1ICrVc11WUVy2UR9jUGn3o3 WpJC35pB+//QyJqTgdeLbbq4fRT4ZfnQ X-Google-Smtp-Source: AGHT+IFiGJRnJjrZNhyj5jgm+uuxuvBMYLtUuP1w+nzjjLtSslpV/ABAw3xII4IPJpL90N4ADCCWLQ== X-Received: by 2002:a17:902:ce90:b0:1d4:43a5:a82a with SMTP id f16-20020a170902ce9000b001d443a5a82amr22762224plg.126.1704329978874; Wed, 03 Jan 2024 16:59:38 -0800 (PST) Received: from lvnvda5233.lvn.broadcom.net ([192.19.161.250]) by smtp.gmail.com with ESMTPSA id s2-20020a170902b18200b001d46a313b42sm16290411plr.268.2024.01.03.16.59.37 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 03 Jan 2024 16:59:38 -0800 (PST) From: Michael Chan To: davem@davemloft.net Cc: netdev@vger.kernel.org, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, pavan.chebbi@broadcom.com, andrew.gospodarek@broadcom.com, arnd@kernel.org Subject: [PATCH net] bnxt_en: Remove mis-applied code from bnxt_cfg_ntp_filters() Date: Wed, 3 Jan 2024 16:59:24 -0800 Message-Id: <20240104005924.40813-1-michael.chan@broadcom.com> X-Mailer: git-send-email 2.32.0 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Delegate: kuba@kernel.org The 2 lines to check for the BNXT_HWRM_PF_UNLOAD_SP_EVENT bit was mis-applied to bnxt_cfg_ntp_filters() and should have been applied to bnxt_sp_task(). Fixes: 19241368443f ("bnxt_en: Send PF driver unload notification to all VFs.") Reviewed-by: Andy Gospodarek Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c index 579eebb6fc56..e1f1e646cf48 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c @@ -12093,6 +12093,8 @@ static void bnxt_sp_task(struct work_struct *work) bnxt_cfg_ntp_filters(bp); if (test_and_clear_bit(BNXT_HWRM_EXEC_FWD_REQ_SP_EVENT, &bp->sp_event)) bnxt_hwrm_exec_fwd_req(bp); + if (test_and_clear_bit(BNXT_HWRM_PF_UNLOAD_SP_EVENT, &bp->sp_event)) + netdev_info(bp->dev, "Receive PF driver unload event!\n"); if (test_and_clear_bit(BNXT_PERIODIC_STATS_SP_EVENT, &bp->sp_event)) { bnxt_hwrm_port_qstats(bp, 0); bnxt_hwrm_port_qstats_ext(bp, 0); @@ -13093,8 +13095,6 @@ static void bnxt_cfg_ntp_filters(struct bnxt *bp) } } } - if (test_and_clear_bit(BNXT_HWRM_PF_UNLOAD_SP_EVENT, &bp->sp_event)) - netdev_info(bp->dev, "Receive PF driver unload event!\n"); } #else