From patchwork Fri Jan 5 23:54:37 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Chan X-Patchwork-Id: 13512620 X-Patchwork-Delegate: kuba@kernel.org Received: from mail-qt1-f178.google.com (mail-qt1-f178.google.com [209.85.160.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 44C73360B0 for ; Fri, 5 Jan 2024 23:54:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="CShuAdkq" Received: by mail-qt1-f178.google.com with SMTP id d75a77b69052e-427f4407624so706761cf.3 for ; Fri, 05 Jan 2024 15:54:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1704498898; x=1705103698; darn=vger.kernel.org; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=HK2QFqPfaMzFix+5QTIBKxByrszzO7GRRgkLhawgCp8=; b=CShuAdkqRwWskg6fyDmMvL3xgRfg/w1WvTSmRwgIh0D0kjgbBdKVIt76Hua7H1rNXs hbwv2tWxFMdcWk0hi485fAs9inrNTHUAleD3x3dghk1L3s2XNMJ2a6aPr93+P0oPChUj 9nYx3/qStWNKCTID0uaMvviRvuj3Rb2dz5jqY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704498898; x=1705103698; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HK2QFqPfaMzFix+5QTIBKxByrszzO7GRRgkLhawgCp8=; b=GMAlDbBRVJDcinC8OiILNvUw7Y9kgDfDAMedTsNygjpkU6PVNnhGK3440Dv8Lk1lUo HFzpR6mykFkA61XEBq7RVlJoQnoofFLaRAz/S6LO1ygUc6QoLnuCvfEOS3RusZ9NjJDi Yr45wLnu04pYifDHiTcSCYPsG2osb9wFynuqLgKiqS1c1DMiuozMWlTcshg16jfAkbSf a6hQqvVvA67yy8EzMD36ST2RchQJfff8Ewm4HV0DgJdW3zHRYAJYMa5ezr4v/ka5aBFn dumCvRFeWeYUX/Bw3zCms3cyT8V3O2LJegceelwMxhj9XoStPCOy3hp8YEABqs+dR7QE SAOw== X-Gm-Message-State: AOJu0Yz1RA8G82ynrKq3HgyENgP6c4bhOtJ2DQCCc5N8EFiRZIScvf7b WZ4KYuzoY2o77wdyj+0IuyTy7M6TvnSN X-Google-Smtp-Source: AGHT+IHwdG36HKWBlgVrLAqUm91FFSJE7nOL0a/y8d8vNPdW45JxRBYxvl8jb7PRhuDynjPLZMqaLQ== X-Received: by 2002:a05:622a:1755:b0:428:4716:be75 with SMTP id l21-20020a05622a175500b004284716be75mr315298qtk.21.1704498898091; Fri, 05 Jan 2024 15:54:58 -0800 (PST) Received: from lvnvda5233.lvn.broadcom.net ([192.19.161.250]) by smtp.gmail.com with ESMTPSA id fb27-20020a05622a481b00b00427f0fdcd44sm1185612qtb.1.2024.01.05.15.54.56 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 Jan 2024 15:54:57 -0800 (PST) From: Michael Chan To: davem@davemloft.net Cc: netdev@vger.kernel.org, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, pavan.chebbi@broadcom.com, andrew.gospodarek@broadcom.com, horms@kernel.org Subject: [PATCH net-next 1/3] bnxt_en: Remove unneeded variable in bnxt_hwrm_clear_vnic_filter() Date: Fri, 5 Jan 2024 15:54:37 -0800 Message-Id: <20240105235439.28282-2-michael.chan@broadcom.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20240105235439.28282-1-michael.chan@broadcom.com> References: <20240105235439.28282-1-michael.chan@broadcom.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Delegate: kuba@kernel.org After recent refactoring, this function doesn't return error any more. Remove the unneeded rc variable and change the function to void. The caller is not checking for the return value. Fixes: 96c9bedc755e ("bnxt_en: Refactor L2 filter alloc/free firmware commands.") Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202401041942.qrB1amZM-lkp@intel.com/ Signed-off-by: Michael Chan Reviewed-by: Simon Horman --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c index b70ddd33e9ed..fb5af8a34c8f 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c @@ -5752,10 +5752,9 @@ static int bnxt_hwrm_set_vnic_filter(struct bnxt *bp, u16 vnic_id, u16 idx, return rc; } -static int bnxt_hwrm_clear_vnic_filter(struct bnxt *bp) +static void bnxt_hwrm_clear_vnic_filter(struct bnxt *bp) { u16 i, j, num_of_vnics = 1; /* only vnic 0 supported */ - int rc = 0; /* Any associated ntuple filters will also be cleared by firmware. */ for (i = 0; i < num_of_vnics; i++) { @@ -5769,8 +5768,6 @@ static int bnxt_hwrm_clear_vnic_filter(struct bnxt *bp) } vnic->uc_filter_count = 0; } - - return rc; } #define BNXT_DFLT_TUNL_TPA_BMAP \