| Message ID | 20240125014502.3527275-1-fujita.tomonori@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 1d4046b5714200ad3a20be09843a63c1c1c9dafe |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] rust: phy: use `srctree`-relative links | expand |
On Wed, Jan 24, 2024 at 8:47 PM FUJITA Tomonori <fujita.tomonori@gmail.com> wrote: > > The relative paths like the following are bothersome and don't work > with `O=` builds: > > //! C headers: [`include/linux/phy.h`](../../../../../../../include/linux/phy.h). > > This updates such links by using the `srctree`-relative link feature > introduced in 6.8-rc1 like: > > //! C headers: [`include/linux/phy.h`](srctree/include/linux/phy.h). > > Signed-off-by: FUJITA Tomonori <fujita.tomonori@gmail.com> Link: https://lore.kernel.org/lkml/20231215235428.243211-1-ojeda@kernel.org/ Reviewed-by: Trevor Gross <tmgross@umich.edu>
Hello: This patch was applied to netdev/net-next.git (main) by David S. Miller <davem@davemloft.net>: On Thu, 25 Jan 2024 10:45:01 +0900 you wrote: > The relative paths like the following are bothersome and don't work > with `O=` builds: > > //! C headers: [`include/linux/phy.h`](../../../../../../../include/linux/phy.h). > > This updates such links by using the `srctree`-relative link feature > introduced in 6.8-rc1 like: > > [...] Here is the summary with links: - [net-next] rust: phy: use `srctree`-relative links https://git.kernel.org/netdev/net-next/c/1d4046b57142 You are awesome, thank you!
diff --git a/rust/kernel/net/phy.rs b/rust/kernel/net/phy.rs index e457b3c7cb2f..203918192a1f 100644 --- a/rust/kernel/net/phy.rs +++ b/rust/kernel/net/phy.rs @@ -4,7 +4,7 @@ //! Network PHY device. //! -//! C headers: [`include/linux/phy.h`](../../../../../../../include/linux/phy.h). +//! C headers: [`include/linux/phy.h`](srctree/include/linux/phy.h). use crate::{bindings, error::*, prelude::*, str::CStr, types::Opaque}; @@ -16,7 +16,7 @@ /// /// Some of PHY drivers access to the state of PHY's software state machine. /// -/// [`enum phy_state`]: ../../../../../../../include/linux/phy.h +/// [`enum phy_state`]: srctree/include/linux/phy.h #[derive(PartialEq, Eq)] pub enum DeviceState { /// PHY device and driver are not ready for anything. @@ -61,7 +61,7 @@ pub enum DuplexMode { /// Referencing a `phy_device` using this struct asserts that you are in /// a context where all methods defined on this struct are safe to call. /// -/// [`struct phy_device`]: ../../../../../../../include/linux/phy.h +/// [`struct phy_device`]: srctree/include/linux/phy.h // During the calls to most functions in [`Driver`], the C side (`PHYLIB`) holds a lock that is // unique for every instance of [`Device`]. `PHYLIB` uses a different serialization technique for // [`Driver::resume`] and [`Driver::suspend`]: `PHYLIB` updates `phy_device`'s state with @@ -486,7 +486,7 @@ impl<T: Driver> Adapter<T> { /// /// `self.0` is always in a valid state. /// -/// [`struct phy_driver`]: ../../../../../../../include/linux/phy.h +/// [`struct phy_driver`]: srctree/include/linux/phy.h #[repr(transparent)] pub struct DriverVTable(Opaque<bindings::phy_driver>);
The relative paths like the following are bothersome and don't work with `O=` builds: //! C headers: [`include/linux/phy.h`](../../../../../../../include/linux/phy.h). This updates such links by using the `srctree`-relative link feature introduced in 6.8-rc1 like: //! C headers: [`include/linux/phy.h`](srctree/include/linux/phy.h). Signed-off-by: FUJITA Tomonori <fujita.tomonori@gmail.com> --- rust/kernel/net/phy.rs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) base-commit: fa47527c71dceb2fd4fb3b17104df53f7aed8d49