| Message ID | 20240204083828.1511334-1-liuhangbin@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] selftests: bonding: fix macvlan2's namespace name | expand |
On Sun, Feb 04, 2024 at 04:38:28PM +0800, Hangbin Liu wrote: > The m2's ns name should be m2-xxxxxx, not m1. > > Fixes: 246af950b940 ("selftests: bonding: add macvlan over bond testing") > Signed-off-by: Hangbin Liu <liuhangbin@gmail.com> Hi Hangbin Liu, I agree this is a nice change. But it is not clear to me that this is fixing a bug. > --- > tools/testing/selftests/drivers/net/bonding/bond_macvlan.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/drivers/net/bonding/bond_macvlan.sh b/tools/testing/selftests/drivers/net/bonding/bond_macvlan.sh > index dc99e4ac262e..969bf9af1b94 100755 > --- a/tools/testing/selftests/drivers/net/bonding/bond_macvlan.sh > +++ b/tools/testing/selftests/drivers/net/bonding/bond_macvlan.sh > @@ -7,7 +7,7 @@ lib_dir=$(dirname "$0") > source ${lib_dir}/bond_topo_2d1c.sh > > m1_ns="m1-$(mktemp -u XXXXXX)" > -m2_ns="m1-$(mktemp -u XXXXXX)" > +m2_ns="m2-$(mktemp -u XXXXXX)" > m1_ip4="192.0.2.11" > m1_ip6="2001:db8::11" > m2_ip4="192.0.2.12" > -- > 2.43.0 > >
On Tue, 6 Feb 2024 15:35:15 +0000 Simon Horman wrote: > On Sun, Feb 04, 2024 at 04:38:28PM +0800, Hangbin Liu wrote: > > The m2's ns name should be m2-xxxxxx, not m1. > > > > Fixes: 246af950b940 ("selftests: bonding: add macvlan over bond testing") > > Signed-off-by: Hangbin Liu <liuhangbin@gmail.com> > > Hi Hangbin Liu, > > I agree this is a nice change. > But it is not clear to me that this is fixing a bug. Agreed, very unlikely mktemp would give us a collision. Please resend for net-next with no fixes tag.
On Tue, Feb 06, 2024 at 03:35:15PM +0000, Simon Horman wrote: > On Sun, Feb 04, 2024 at 04:38:28PM +0800, Hangbin Liu wrote: > > The m2's ns name should be m2-xxxxxx, not m1. > > > > Fixes: 246af950b940 ("selftests: bonding: add macvlan over bond testing") > > Signed-off-by: Hangbin Liu <liuhangbin@gmail.com> > > Hi Hangbin Liu, > > I agree this is a nice change. > But it is not clear to me that this is fixing a bug. Ah, you are right. I also just realise that the previous code also works as we use mktemp, so the m1 and m2's name are unique, although the m2's name using m1 as prefix. Please feel free to drop this patch. I can do the name modification in future when updating the bond_macvlan test. Thanks Hangbin > > > --- > > tools/testing/selftests/drivers/net/bonding/bond_macvlan.sh | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tools/testing/selftests/drivers/net/bonding/bond_macvlan.sh b/tools/testing/selftests/drivers/net/bonding/bond_macvlan.sh > > index dc99e4ac262e..969bf9af1b94 100755 > > --- a/tools/testing/selftests/drivers/net/bonding/bond_macvlan.sh > > +++ b/tools/testing/selftests/drivers/net/bonding/bond_macvlan.sh > > @@ -7,7 +7,7 @@ lib_dir=$(dirname "$0") > > source ${lib_dir}/bond_topo_2d1c.sh > > > > m1_ns="m1-$(mktemp -u XXXXXX)" > > -m2_ns="m1-$(mktemp -u XXXXXX)" > > +m2_ns="m2-$(mktemp -u XXXXXX)" > > m1_ip4="192.0.2.11" > > m1_ip6="2001:db8::11" > > m2_ip4="192.0.2.12" > > -- > > 2.43.0 > > > >
diff --git a/tools/testing/selftests/drivers/net/bonding/bond_macvlan.sh b/tools/testing/selftests/drivers/net/bonding/bond_macvlan.sh index dc99e4ac262e..969bf9af1b94 100755 --- a/tools/testing/selftests/drivers/net/bonding/bond_macvlan.sh +++ b/tools/testing/selftests/drivers/net/bonding/bond_macvlan.sh @@ -7,7 +7,7 @@ lib_dir=$(dirname "$0") source ${lib_dir}/bond_topo_2d1c.sh m1_ns="m1-$(mktemp -u XXXXXX)" -m2_ns="m1-$(mktemp -u XXXXXX)" +m2_ns="m2-$(mktemp -u XXXXXX)" m1_ip4="192.0.2.11" m1_ip6="2001:db8::11" m2_ip4="192.0.2.12"
The m2's ns name should be m2-xxxxxx, not m1. Fixes: 246af950b940 ("selftests: bonding: add macvlan over bond testing") Signed-off-by: Hangbin Liu <liuhangbin@gmail.com> --- tools/testing/selftests/drivers/net/bonding/bond_macvlan.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)