From patchwork Sat Mar 2 07:22:37 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Saeed Mahameed X-Patchwork-Id: 13579459 X-Patchwork-Delegate: kuba@kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D56114F86 for ; Sat, 2 Mar 2024 07:23:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709364206; cv=none; b=CRhKk5c/b0XPCw4dHYR3CwE1lu3nw8VGPhfXPBpBzEpSs8/EGtEYzWjDShNwCMcDzq9QRGhH4zZiW2RkFTCxnPkMmDM4UnXZm89xW7PQj6g0IUM17/OPFZyOL1BXSAIWugKP2DEyoE1q3dqKv7+qUMOQz7GAJDWymwl1wYq8a8g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709364206; c=relaxed/simple; bh=8DI8AmyIHtBjzKKYwZA4C5/bbYODVCu2V7iG9u35oz0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VamMH5QUQKdHS0TbvVPehJPUYDFH4qd/Y4quzg+Ju9lPchqLx6apjRR/FRQ8s6rnmNTA1O9sKbRm7ZCfHAcfG5Z08kpBm3E8TpDWEzwNeD9ZwVgbUqO+ely8ssl9HRYkMObSQ+kh5tof+w+dYzyIViLJbFCeBMsCN5QMjy9PiT0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=L4sWO2Iy; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="L4sWO2Iy" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C9A77C43394; Sat, 2 Mar 2024 07:23:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709364206; bh=8DI8AmyIHtBjzKKYwZA4C5/bbYODVCu2V7iG9u35oz0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=L4sWO2Iy3xr6lmtbaS89PF6WuCtJ51FCaeBOuWLstI2uCCZMgtIBSW3NBxlJ14UwO bHjpSMkdDSMheA/5VjVAecVmOQttZhaTJhzhuIWBu+56Yc3Hz4E54XsV0cxM5uqOem ohrTGDLy8BT3CqtoA26MBJ4unVwlH8/LS+aD7nyu4VZMLdoGwHHYoT6BVSNAW25DCc T3T68XFHy/BUw0Jqb5jWoxoCsIN4Bj5TaXYt/SolZftpEmOZnklJ1wrZI5eHLmsBY/ pGVyxnvtOLQ0GZZGVJWN6uvba6vPf4+U/f+fOAtJMgZKBYxNEU/7LJmg9Atx77b+4D /heRK7IGOiHmA== From: Saeed Mahameed To: "David S. Miller" , Jakub Kicinski , Paolo Abeni , Eric Dumazet Cc: Saeed Mahameed , netdev@vger.kernel.org, Tariq Toukan , Gal Pressman , Leon Romanovsky , sridhar.samudrala@intel.com, Jay Vosburgh , Jiri Pirko , Greg Kroah-Hartman Subject: [net-next V4 07/15] net/mlx5: SD, Add debugfs Date: Fri, 1 Mar 2024 23:22:37 -0800 Message-ID: <20240302072246.67920-8-saeed@kernel.org> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240302072246.67920-1-saeed@kernel.org> References: <20240302072246.67920-1-saeed@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Delegate: kuba@kernel.org From: Tariq Toukan Add debugfs entries that describe the Socket-Direct group. Example: $ grep -H . /sys/kernel/debug/mlx5/0000\:08\:00.0/multi-pf/* /sys/kernel/debug/mlx5/0000:08:00.0/multi-pf/group_id:0x00000101 /sys/kernel/debug/mlx5/0000:08:00.0/multi-pf/primary:0000:08:00.0 vhca 0x0 /sys/kernel/debug/mlx5/0000:08:00.0/multi-pf/secondary_0:0000:09:00.0 vhca 0x2 Signed-off-by: Tariq Toukan Signed-off-by: Saeed Mahameed --- .../net/ethernet/mellanox/mlx5/core/lib/sd.c | 34 +++++++++++++++++++ 1 file changed, 34 insertions(+) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lib/sd.c b/drivers/net/ethernet/mellanox/mlx5/core/lib/sd.c index 918138c13a92..5b28084e8a03 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/lib/sd.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/lib/sd.c @@ -6,6 +6,7 @@ #include "lib/mlx5.h" #include "fs_cmd.h" #include +#include #define sd_info(__dev, format, ...) \ dev_info((__dev)->device, "Socket-Direct: " format, ##__VA_ARGS__) @@ -16,6 +17,7 @@ struct mlx5_sd { u32 group_id; u8 host_buses; struct mlx5_devcom_comp_dev *devcom; + struct dentry *dfs; bool primary; union { struct { /* primary */ @@ -391,6 +393,26 @@ static void sd_print_group(struct mlx5_core_dev *primary) MLX5_CAP_GEN(pos, vhca_id)); } +static ssize_t dev_read(struct file *filp, char __user *buf, size_t count, + loff_t *pos) +{ + struct mlx5_core_dev *dev; + char tbuf[32]; + int ret; + + dev = filp->private_data; + ret = snprintf(tbuf, sizeof(tbuf), "%s vhca %#x\n", pci_name(dev->pdev), + MLX5_CAP_GEN(dev, vhca_id)); + + return simple_read_from_buffer(buf, count, pos, tbuf, ret); +} + +static const struct file_operations dev_fops = { + .owner = THIS_MODULE, + .open = simple_open, + .read = dev_read, +}; + int mlx5_sd_init(struct mlx5_core_dev *dev) { struct mlx5_core_dev *primary, *pos, *to; @@ -422,10 +444,20 @@ int mlx5_sd_init(struct mlx5_core_dev *dev) if (err) goto err_sd_unregister; + sd->dfs = debugfs_create_dir("multi-pf", mlx5_debugfs_get_dev_root(primary)); + debugfs_create_x32("group_id", 0400, sd->dfs, &sd->group_id); + debugfs_create_file("primary", 0400, sd->dfs, primary, &dev_fops); + mlx5_sd_for_each_secondary(i, primary, pos) { + char name[32]; + err = sd_cmd_set_secondary(pos, primary, alias_key); if (err) goto err_unset_secondaries; + + snprintf(name, sizeof(name), "secondary_%d", i - 1); + debugfs_create_file(name, 0400, sd->dfs, pos, &dev_fops); + } sd_info(primary, "group id %#x, size %d, combined\n", @@ -439,6 +471,7 @@ int mlx5_sd_init(struct mlx5_core_dev *dev) mlx5_sd_for_each_secondary_to(i, primary, to, pos) sd_cmd_unset_secondary(pos); sd_cmd_unset_primary(primary); + debugfs_remove_recursive(sd->dfs); err_sd_unregister: sd_unregister(dev); err_sd_cleanup: @@ -462,6 +495,7 @@ void mlx5_sd_cleanup(struct mlx5_core_dev *dev) mlx5_sd_for_each_secondary(i, primary, pos) sd_cmd_unset_secondary(pos); sd_cmd_unset_primary(primary); + debugfs_remove_recursive(sd->dfs); sd_info(primary, "group id %#x, uncombined\n", sd->group_id); out: