diff mbox series

[next] net: chelsio: remove unused function calc_tx_descs

Message ID 20240307112237.1982789-1-colin.i.king@gmail.com (mailing list archive)
State Accepted
Commit 9b78bbef5138bee1b6fc08e2b6a2e27f2e382048
Delegated to: Netdev Maintainers
Headers show
Series [next] net: chelsio: remove unused function calc_tx_descs | expand

Checks

Context Check Description
netdev/series_format warning Single patches do not need cover letters; Target tree name not specified in the subject
netdev/tree_selection success Guessed tree name to be net-next
netdev/ynl success Generated files up to date; no warnings/errors; no diff in generated;
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 940 this patch: 940
netdev/build_tools success No tools touched, skip
netdev/cc_maintainers warning 6 maintainers not CCed: rajur@chelsio.com ndesaulniers@google.com llvm@lists.linux.dev nathan@kernel.org morbo@google.com justinstitt@google.com
netdev/build_clang success Errors and warnings before: 958 this patch: 956
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 956 this patch: 956
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 20 lines checked
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 1 now: 0
netdev/contest success net-next-2024-03-07--15-00 (tests: 892)

Commit Message

Colin Ian King March 7, 2024, 11:22 a.m. UTC
The inlined helper function calc_tx_descs is not used and is redundant.
Remove it.

Cleans up clang scan build warning:
drivers/net/ethernet/chelsio/cxgb4/sge.c:814:28: warning: unused
function 'calc_tx_descs' [-Wunused-function]

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
 drivers/net/ethernet/chelsio/cxgb4/sge.c | 14 --------------
 1 file changed, 14 deletions(-)

Comments

patchwork-bot+netdevbpf@kernel.org March 8, 2024, 10:30 a.m. UTC | #1
Hello:

This patch was applied to netdev/net-next.git (main)
by David S. Miller <davem@davemloft.net>:

On Thu,  7 Mar 2024 11:22:37 +0000 you wrote:
> The inlined helper function calc_tx_descs is not used and is redundant.
> Remove it.
> 
> Cleans up clang scan build warning:
> drivers/net/ethernet/chelsio/cxgb4/sge.c:814:28: warning: unused
> function 'calc_tx_descs' [-Wunused-function]
> 
> [...]

Here is the summary with links:
  - [next] net: chelsio: remove unused function calc_tx_descs
    https://git.kernel.org/netdev/net-next/c/9b78bbef5138

You are awesome, thank you!
diff mbox series

Patch

diff --git a/drivers/net/ethernet/chelsio/cxgb4/sge.c b/drivers/net/ethernet/chelsio/cxgb4/sge.c
index b5ff2e1a9975..49d5808b7d11 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/sge.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/sge.c
@@ -803,20 +803,6 @@  static inline unsigned int calc_tx_flits(const struct sk_buff *skb,
 	return flits;
 }
 
-/**
- *	calc_tx_descs - calculate the number of Tx descriptors for a packet
- *	@skb: the packet
- *	@chip_ver: chip version
- *
- *	Returns the number of Tx descriptors needed for the given Ethernet
- *	packet, including the needed WR and CPL headers.
- */
-static inline unsigned int calc_tx_descs(const struct sk_buff *skb,
-					 unsigned int chip_ver)
-{
-	return flits_to_desc(calc_tx_flits(skb, chip_ver));
-}
-
 /**
  *	cxgb4_write_sgl - populate a scatter/gather list for a packet
  *	@skb: the packet