| Message ID | 20240307162943.2523817-1-edumazet@google.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 026763ece881b4c636173c25d012cde085689027 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] ipv6: raw: check sk->sk_rcvbuf earlier | expand |
Eric Dumazet wrote: > There is no point cloning an skb and having to free the clone > if the receive queue of the raw socket is full. > > Signed-off-by: Eric Dumazet <edumazet@google.com> Reviewed-by: Willem de Bruijn <willemb@google.com>
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Thu, 7 Mar 2024 16:29:43 +0000 you wrote: > There is no point cloning an skb and having to free the clone > if the receive queue of the raw socket is full. > > Signed-off-by: Eric Dumazet <edumazet@google.com> > --- > net/ipv6/raw.c | 7 +++++++ > 1 file changed, 7 insertions(+) Here is the summary with links: - [net-next] ipv6: raw: check sk->sk_rcvbuf earlier https://git.kernel.org/netdev/net-next/c/026763ece881 You are awesome, thank you!
diff --git a/net/ipv6/raw.c b/net/ipv6/raw.c index 779274055abf99530048ad4738c2263e97c94cce..ca49e6617afaff3fe6c5f3a174bbe6d96f94ac62 100644 --- a/net/ipv6/raw.c +++ b/net/ipv6/raw.c @@ -160,6 +160,13 @@ static bool ipv6_raw_deliver(struct sk_buff *skb, int nexthdr) if (!raw_v6_match(net, sk, nexthdr, daddr, saddr, inet6_iif(skb), inet6_sdif(skb))) continue; + + if (atomic_read(&sk->sk_rmem_alloc) >= + READ_ONCE(sk->sk_rcvbuf)) { + atomic_inc(&sk->sk_drops); + continue; + } + delivered = true; switch (nexthdr) { case IPPROTO_ICMPV6:
There is no point cloning an skb and having to free the clone if the receive queue of the raw socket is full. Signed-off-by: Eric Dumazet <edumazet@google.com> --- net/ipv6/raw.c | 7 +++++++ 1 file changed, 7 insertions(+)