| Message ID | 20240308001546.19010-1-witu@nvidia.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] devlink: Add comments to use netlink gen tool | expand |
On Fri, 8 Mar 2024 02:15:46 +0200 William Tu wrote: > - /* add new attributes above here, update the policy in devlink.c */ > + /* Add new attributes above here, update the spec in > + * Documentation/netlink/specs/devlink.yaml and re-generate > + * net/devlink/netlink_gen.c. */ > Unless someone feels strongly I reckon we should heed checkpatch's advice and put the */ on a separate line.
On 3/8/24 8:15 PM, Jakub Kicinski wrote: > External email: Use caution opening links or attachments > > > On Fri, 8 Mar 2024 02:15:46 +0200 William Tu wrote: >> - /* add new attributes above here, update the policy in devlink.c */ >> + /* Add new attributes above here, update the spec in >> + * Documentation/netlink/specs/devlink.yaml and re-generate >> + * net/devlink/netlink_gen.c. */ >> > Unless someone feels strongly I reckon we should heed checkpatch's > advice and put the */ on a separate line. > -- > pw-bot: cr Will do, thanks William
diff --git a/include/uapi/linux/devlink.h b/include/uapi/linux/devlink.h index 130cae0d3e20..852ceb21ee69 100644 --- a/include/uapi/linux/devlink.h +++ b/include/uapi/linux/devlink.h @@ -614,7 +614,9 @@ enum devlink_attr { DEVLINK_ATTR_REGION_DIRECT, /* flag */ - /* add new attributes above here, update the policy in devlink.c */ + /* Add new attributes above here, update the spec in + * Documentation/netlink/specs/devlink.yaml and re-generate + * net/devlink/netlink_gen.c. */ __DEVLINK_ATTR_MAX, DEVLINK_ATTR_MAX = __DEVLINK_ATTR_MAX - 1
Add the comment to remind people not to manually modify the net/devlink/netlink_gen.c, but to use tools/net/ynl/ynl-regen.sh to generate it. Signed-off-by: William Tu <witu@nvidia.com> Suggested-by: Jiri Pirko <jiri@nvidia.com> --- include/uapi/linux/devlink.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)