| Message ID | 20240318091541.2595-1-dkirjanov@suse.de (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | b22a3430bd17c4f75e6f113ecfeb8ea386d6b408 |
| Delegated to: | Stephen Hemminger |
| Headers | show |
| Series | [iproute2,v2] ifstat: handle strdup return value | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
Hello: This patch was applied to iproute2/iproute2.git (main) by Stephen Hemminger <stephen@networkplumber.org>: On Mon, 18 Mar 2024 05:15:41 -0400 you wrote: > get_nlmsg_extended is missing the check as > it's done in get_nlmsg > > v2: don't set the errno value explicitly > > Signed-off-by: Denis Kirjanov <dkirjanov@suse.de> > > [...] Here is the summary with links: - [iproute2,v2] ifstat: handle strdup return value https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/commit/?id=b22a3430bd17 You are awesome, thank you!
diff --git a/misc/ifstat.c b/misc/ifstat.c index 685e66c9..352e5622 100644 --- a/misc/ifstat.c +++ b/misc/ifstat.c @@ -140,6 +140,10 @@ static int get_nlmsg_extended(struct nlmsghdr *m, void *arg) n->ifindex = ifsm->ifindex; n->name = strdup(ll_index_to_name(ifsm->ifindex)); + if (!n->name) { + free(n); + return -1; + } if (sub_type == NO_SUB_TYPE) { memcpy(&n->val, RTA_DATA(tb[filter_type]), sizeof(n->val));
get_nlmsg_extended is missing the check as it's done in get_nlmsg v2: don't set the errno value explicitly Signed-off-by: Denis Kirjanov <dkirjanov@suse.de> --- misc/ifstat.c | 4 ++++ 1 file changed, 4 insertions(+)