| Message ID | 20240329160559.249476-1-kuba@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 31974122cfdeaf56abc18d8ab740d580d9833e90 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] selftests: reuseaddr_conflict: add missing new line at the end of the output | expand |
On 3/29/24 9:05 PM, Jakub Kicinski wrote: > The netdev CI runs in a VM and captures serial, so stdout and > stderr get combined. Because there's a missing new line in > stderr the test ends up corrupting KTAP: > > # Successok 1 selftests: net: reuseaddr_conflict > > which should have been: > > # Success > ok 1 selftests: net: reuseaddr_conflict > > Fixes: 422d8dc6fd3a ("selftest: add a reuseaddr test") > Signed-off-by: Jakub Kicinski <kuba@kernel.org> Reviewed-by: Muhammad Usama Anjum <usama.anjum@collabora.com> > --- > Low risk and seems worth backporting to stable, hence the fixes tag. Agreed to back port it as ok or not ok must appear at the start of the line to indicate the status of the test. > > CC: shuah@kernel.org > CC: jbacik@fb.com > CC: linux-kselftest@vger.kernel.org > --- > tools/testing/selftests/net/reuseaddr_conflict.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/net/reuseaddr_conflict.c b/tools/testing/selftests/net/reuseaddr_conflict.c > index 7c5b12664b03..bfb07dc49518 100644 > --- a/tools/testing/selftests/net/reuseaddr_conflict.c > +++ b/tools/testing/selftests/net/reuseaddr_conflict.c > @@ -109,6 +109,6 @@ int main(void) > fd1 = open_port(0, 1); > if (fd1 >= 0) > error(1, 0, "Was allowed to create an ipv4 reuseport on an already bound non-reuseport socket with no ipv6"); > - fprintf(stderr, "Success"); > + fprintf(stderr, "Success\n"); > return 0; > }
Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski <kuba@kernel.org>: On Fri, 29 Mar 2024 09:05:59 -0700 you wrote: > The netdev CI runs in a VM and captures serial, so stdout and > stderr get combined. Because there's a missing new line in > stderr the test ends up corrupting KTAP: > > # Successok 1 selftests: net: reuseaddr_conflict > > which should have been: > > [...] Here is the summary with links: - [net] selftests: reuseaddr_conflict: add missing new line at the end of the output https://git.kernel.org/netdev/net/c/31974122cfde You are awesome, thank you!
diff --git a/tools/testing/selftests/net/reuseaddr_conflict.c b/tools/testing/selftests/net/reuseaddr_conflict.c index 7c5b12664b03..bfb07dc49518 100644 --- a/tools/testing/selftests/net/reuseaddr_conflict.c +++ b/tools/testing/selftests/net/reuseaddr_conflict.c @@ -109,6 +109,6 @@ int main(void) fd1 = open_port(0, 1); if (fd1 >= 0) error(1, 0, "Was allowed to create an ipv4 reuseport on an already bound non-reuseport socket with no ipv6"); - fprintf(stderr, "Success"); + fprintf(stderr, "Success\n"); return 0; }
The netdev CI runs in a VM and captures serial, so stdout and stderr get combined. Because there's a missing new line in stderr the test ends up corrupting KTAP: # Successok 1 selftests: net: reuseaddr_conflict which should have been: # Success ok 1 selftests: net: reuseaddr_conflict Fixes: 422d8dc6fd3a ("selftest: add a reuseaddr test") Signed-off-by: Jakub Kicinski <kuba@kernel.org> --- Low risk and seems worth backporting to stable, hence the fixes tag. CC: shuah@kernel.org CC: jbacik@fb.com CC: linux-kselftest@vger.kernel.org --- tools/testing/selftests/net/reuseaddr_conflict.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)