From patchwork Tue Apr 2 09:37:53 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavan Chebbi X-Patchwork-Id: 13613600 X-Patchwork-Delegate: kuba@kernel.org Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 27A9458105 for ; Tue, 2 Apr 2024 09:36:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712050578; cv=none; b=TkKNViV51A5fMc+3BTZOQeGgSGY2lq7/SNrMWlvc2idH8a+SCprzs6lfKW3dwioQhMZeXLGZJuvE0WK7vtoh2RHxPLhhhSGe39aCjLcv6PvMBGeQiuLXTq3vPBV/UKxdiK6vY6sLXg0N/b5rld0F7cfVHiJ1WTCuaUFPZ6TAVnc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712050578; c=relaxed/simple; bh=oiVjuNphKIaHqFRrboIBJTKQkyPa+m93OQ0UI2bySpU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=YVfILrCKRsum92wtqIU8JHqvfgpOAxEaCyFh4gfEQUAZOWv60YuvKzH7S98qp8tUd1kBj72JKvDR/qO2JDE4w2febkkn1cX9+gEvsTjZk6ATLhOSAnXQQx7BQG6ikSwQGOP3WJX6oOfE5HR6jqCR4ihyUGiJfiUgT7WnN86m2lE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=HzwqU7Io; arc=none smtp.client-ip=209.85.210.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="HzwqU7Io" Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-6eaf1005fcaso1935778b3a.3 for ; Tue, 02 Apr 2024 02:36:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1712050576; x=1712655376; darn=vger.kernel.org; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=b+m4kHHFYY28ecUPVtXSzISJ47PGkToHXp4+3MPAI0Y=; b=HzwqU7IomKP0y41F+euZp6liOr+/ayK2jSBaYVPHs7kJUwvZKLY4IgfVOFH9PjNAb1 BPBxoCSTJaWhip64lXcYcFkFsR9k9G4sUWksSOPNUyGodfiigAwhqs+4w1z1cdQG7IWh W0/JeIeGbI/sFrJJkoF9imZnPIa3NmqCbDR0U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712050576; x=1712655376; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=b+m4kHHFYY28ecUPVtXSzISJ47PGkToHXp4+3MPAI0Y=; b=u/dLUb7HOpIFsx7vef6CezopBYFAuYbk9mfUKx9XGhh/XEgnszU2BDsf2OZwb00pkl KW1AVOc3b+PQOfYBUTm6GT805fQKKZf/+c8JzIf9TDr9OHF5n3YMMjqTu0NUY/GFTSwL IKLSvYNf3yZIxwmfI5usinA6HOCPI8WB2S8R9i9ggfQWzZH3kNROeM88IAguloS+wp2h 68CmELOhKTD6BPH9vfljnUn/F4x5s48oVbhQJfYjTmGFFzPFZCENyvKFqpdHwtaKukTK y6KpND/4+e7nGeOE1WEBEVkurM2vhhGgnkyB0DW/RM/8hWsBATFXnDAQGN/0QSnIG4js oi6A== X-Forwarded-Encrypted: i=1; AJvYcCXw4Zydbf2NbWgmYYZU4sV5QZEkDXZWUvl0gAj622NgN8xgJx6hdVdTH2ERS8/yH/ajw+89ndMuW6NtUDAh+utqCxYtkDMQ X-Gm-Message-State: AOJu0YwZ2U92GtZvbVkQWfNaedR8oHMCmsO+H91k0U/LrDcJH4xKbDtC 3iup1x2IwS9o9dpeXhNREnEDIp0cPJ8gBhP1jZ7iC7/ygzg81U4EYoR2QiMhTw== X-Google-Smtp-Source: AGHT+IGbNtXE6g0K0VOYFL1D+6UbcJQBQ5eu/VLBjJe60v1aSS3+CB8HavEzt/PmqyJhqAZaejX8tg== X-Received: by 2002:a05:6a00:2d17:b0:6e5:eab8:4db8 with SMTP id fa23-20020a056a002d1700b006e5eab84db8mr12274751pfb.17.1712050576314; Tue, 02 Apr 2024 02:36:16 -0700 (PDT) Received: from PC-MID-R740.dhcp.broadcom.net ([192.19.234.250]) by smtp.gmail.com with ESMTPSA id q19-20020a62e113000000b006e5a3db5875sm9702087pfh.13.2024.04.02.02.36.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Apr 2024 02:36:15 -0700 (PDT) From: Pavan Chebbi To: michael.chan@broadcom.com Cc: davem@davemloft.net, edumazet@google.com, gospo@broadcom.com, kuba@kernel.org, netdev@vger.kernel.org, pabeni@redhat.com, Sreekanth Reddy , Kalesh AP , Somnath Kotur , Pavan Chebbi Subject: [PATCH net-next v2 7/7] bnxt_en: Add warning message about disallowed speed change Date: Tue, 2 Apr 2024 02:37:53 -0700 Message-Id: <20240402093753.331120-8-pavan.chebbi@broadcom.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20240402093753.331120-1-pavan.chebbi@broadcom.com> References: <20240402093753.331120-1-pavan.chebbi@broadcom.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Delegate: kuba@kernel.org From: Sreekanth Reddy Some chips may not allow changing default speed when dual rate transceivers modules are used. Firmware on those chips will indicate the same to the driver. Add a warning message when speed change is not supported because a dual rate transceiver is detected by the NIC. Signed-off-by: Sreekanth Reddy Reviewed-by: Kalesh AP Reviewed-by: Somnath Kotur Reviewed-by: Michael Chan Signed-off-by: Pavan Chebbi --- v2: Fixed formatting of netdev_warn to avoid unnecessary line break. --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c index 3982858a59a1..795f3f957eb5 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c @@ -2525,6 +2525,9 @@ static bool bnxt_event_error_report(struct bnxt *bp, u32 data1, u32 data2) } return false; } + case ASYNC_EVENT_CMPL_ERROR_REPORT_BASE_EVENT_DATA1_ERROR_TYPE_DUAL_DATA_RATE_NOT_SUPPORTED: + netdev_warn(bp->dev, "Speed change not supported with dual rate transceivers on this board\n"); + break; default: netdev_err(bp->dev, "FW reported unknown error type %u\n", err_type);