| Message ID | 20240404130751.2532093-1-edumazet@google.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 802e12ff9cbff3bafb0b6f0fe79cff04dce9de16 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] inet: frags: delay fqdir_free_fn() | expand |
Hello: This patch was applied to netdev/net-next.git (main) by David S. Miller <davem@davemloft.net>: On Thu, 4 Apr 2024 13:07:51 +0000 you wrote: > fqdir_free_fn() is using very expensive rcu_barrier() > > When one netns is dismantled, we often call fqdir_exit() > multiple times, typically lauching fqdir_free_fn() twice. > > Delaying by one second fqdir_free_fn() helps to reduce > the number of rcu_barrier() calls, and lock contention > on rcu_state.barrier_mutex. > > [...] Here is the summary with links: - [net-next] inet: frags: delay fqdir_free_fn() https://git.kernel.org/netdev/net-next/c/802e12ff9cbf You are awesome, thank you!
diff --git a/net/ipv4/inet_fragment.c b/net/ipv4/inet_fragment.c index c88c9034d63004e7763f60b3211dc319172c8d06..faaec92a46ac03e1fd4d1dfaf9a7fa080148ca2b 100644 --- a/net/ipv4/inet_fragment.c +++ b/net/ipv4/inet_fragment.c @@ -175,7 +175,7 @@ static void fqdir_free_fn(struct work_struct *work) } } -static DECLARE_WORK(fqdir_free_work, fqdir_free_fn); +static DECLARE_DELAYED_WORK(fqdir_free_work, fqdir_free_fn); static void fqdir_work_fn(struct work_struct *work) { @@ -184,7 +184,7 @@ static void fqdir_work_fn(struct work_struct *work) rhashtable_free_and_destroy(&fqdir->rhashtable, inet_frags_free_cb, NULL); if (llist_add(&fqdir->free_list, &fqdir_free_list)) - queue_work(system_wq, &fqdir_free_work); + queue_delayed_work(system_wq, &fqdir_free_work, HZ); } int fqdir_init(struct fqdir **fqdirp, struct inet_frags *f, struct net *net)
fqdir_free_fn() is using very expensive rcu_barrier() When one netns is dismantled, we often call fqdir_exit() multiple times, typically lauching fqdir_free_fn() twice. Delaying by one second fqdir_free_fn() helps to reduce the number of rcu_barrier() calls, and lock contention on rcu_state.barrier_mutex. Signed-off-by: Eric Dumazet <edumazet@google.com> --- net/ipv4/inet_fragment.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)