| Message ID | 20240422102546.2494-1-fw@strlen.de (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 8e2b318a65c30626d49d3bf1940037afb386e596 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] selftests: netfilter: nft_zones_many.sh: set ct sysctl after ruleset load | expand |
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Mon, 22 Apr 2024 12:25:42 +0200 you wrote: > nf_conntrack_udp_timeout sysctl only exist once conntrack module is loaded, > if this test runs standalone on a modular kernel sysctl setting fails, > this can result in test failure as udp conntrack entries expire too fast. > > Signed-off-by: Florian Westphal <fw@strlen.de> > --- > tools/testing/selftests/net/netfilter/nft_zones_many.sh | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Here is the summary with links: - [net-next] selftests: netfilter: nft_zones_many.sh: set ct sysctl after ruleset load https://git.kernel.org/netdev/net-next/c/8e2b318a65c3 You are awesome, thank you!
diff --git a/tools/testing/selftests/net/netfilter/nft_zones_many.sh b/tools/testing/selftests/net/netfilter/nft_zones_many.sh index db53de348783..4ad75038f6ff 100755 --- a/tools/testing/selftests/net/netfilter/nft_zones_many.sh +++ b/tools/testing/selftests/net/netfilter/nft_zones_many.sh @@ -28,7 +28,6 @@ fi test_zones() { local max_zones=$1 -ip netns exec "$ns1" sysctl -q net.netfilter.nf_conntrack_udp_timeout=3600 ip netns exec "$ns1" nft -f /dev/stdin<<EOF flush ruleset table inet raw { @@ -46,6 +45,9 @@ if [ "$?" -ne 0 ];then echo "SKIP: Cannot add nftables rules" exit $ksft_skip fi + + ip netns exec "$ns1" sysctl -q net.netfilter.nf_conntrack_udp_timeout=3600 + ( echo "add element inet raw rndzone {" for i in $(seq 1 "$max_zones");do
nf_conntrack_udp_timeout sysctl only exist once conntrack module is loaded, if this test runs standalone on a modular kernel sysctl setting fails, this can result in test failure as udp conntrack entries expire too fast. Signed-off-by: Florian Westphal <fw@strlen.de> --- tools/testing/selftests/net/netfilter/nft_zones_many.sh | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)