| Message ID | 20240423085039.26957-1-kabel@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 6999e0fc9a552ce98fcc66bee3dca7e55fba0ed3 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next,v2,1/2] net: sfp: update comment for FS SFP-10G-T quirk | expand |
Tue, Apr 23, 2024 at 10:50:38AM CEST, kabel@kernel.org wrote: >Update the comment for the Fibrestore SFP-10G-T module: since commit >e9301af385e7 ("net: sfp: fix PHY discovery for FS SFP-10G-T module") >we also do a 4 second wait before probing the PHY. > >Fixes: e9301af385e7 ("net: sfp: fix PHY discovery for FS SFP-10G-T module") >Signed-off-by: Marek Behún <kabel@kernel.org> >Reviewed-by: Andrew Lunn <andrew@lunn.ch> Reviewed-by: Jiri Pirko <jiri@nvidia.com> For patchsets, could you please next time provide a cover letter. Even very simple one would do. Thanks!
Hello: This series was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Tue, 23 Apr 2024 10:50:38 +0200 you wrote: > Update the comment for the Fibrestore SFP-10G-T module: since commit > e9301af385e7 ("net: sfp: fix PHY discovery for FS SFP-10G-T module") > we also do a 4 second wait before probing the PHY. > > Fixes: e9301af385e7 ("net: sfp: fix PHY discovery for FS SFP-10G-T module") > Signed-off-by: Marek Behún <kabel@kernel.org> > Reviewed-by: Andrew Lunn <andrew@lunn.ch> > > [...] Here is the summary with links: - [net-next,v2,1/2] net: sfp: update comment for FS SFP-10G-T quirk https://git.kernel.org/netdev/net-next/c/6999e0fc9a55 - [net-next,v2,2/2] net: sfp: enhance quirk for Fibrestore 2.5G copper SFP module https://git.kernel.org/netdev/net-next/c/cd4a32e60061 You are awesome, thank you!
diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c index 6e7639fc64dd..1af15f2da8a6 100644 --- a/drivers/net/phy/sfp.c +++ b/drivers/net/phy/sfp.c @@ -468,8 +468,9 @@ static const struct sfp_quirk sfp_quirks[] = { SFP_QUIRK("ALCATELLUCENT", "3FE46541AA", sfp_quirk_2500basex, sfp_fixup_nokia), - // Fiberstore SFP-10G-T doesn't identify as copper, and uses the - // Rollball protocol to talk to the PHY. + // Fiberstore SFP-10G-T doesn't identify as copper, uses the Rollball + // protocol to talk to the PHY and needs 4 sec wait before probing the + // PHY. SFP_QUIRK_F("FS", "SFP-10G-T", sfp_fixup_fs_10gt), // Fiberstore GPON-ONU-34-20BI can operate at 2500base-X, but report 1.2GBd
Update the comment for the Fibrestore SFP-10G-T module: since commit e9301af385e7 ("net: sfp: fix PHY discovery for FS SFP-10G-T module") we also do a 4 second wait before probing the PHY. Fixes: e9301af385e7 ("net: sfp: fix PHY discovery for FS SFP-10G-T module") Signed-off-by: Marek Behún <kabel@kernel.org> Reviewed-by: Andrew Lunn <andrew@lunn.ch> --- Since this only fixes a comment and the next patch is based on this one, I am sending to net-next instead of net. --- drivers/net/phy/sfp.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)