| Message ID | 20240426091227.78060-3-ast@fiberby.net (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | fcee2065a178f78be6fd516302830378b17dba3d |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: qede: avoid overruling error codes | expand |
On Fri, Apr 26, 2024 at 09:12:24AM +0000, Asbjørn Sloth Tønnesen wrote: > In qede_add_tc_flower_fltr(), when calling > qede_parse_flow_attr() then the return code > was only used for a non-zero check, and then > -EINVAL was returned. > > qede_parse_flow_attr() can currently fail with: > * -EINVAL > * -EOPNOTSUPP > * -EPROTONOSUPPORT > > This patch changes the code to use the actual > return code, not just return -EINVAL. > > The blaimed commit introduced these functions. > > Only compile tested. > > Fixes: 2ce9c93eaca6 ("qede: Ingress tc flower offload (drop action) support.") > Signed-off-by: Asbjørn Sloth Tønnesen <ast@fiberby.net> Reviewed-by: Simon Horman <horms@kernel.org>
diff --git a/drivers/net/ethernet/qlogic/qede/qede_filter.c b/drivers/net/ethernet/qlogic/qede/qede_filter.c index 8ecdfa36a685..25ef0f4258cb 100644 --- a/drivers/net/ethernet/qlogic/qede/qede_filter.c +++ b/drivers/net/ethernet/qlogic/qede/qede_filter.c @@ -1879,10 +1879,9 @@ int qede_add_tc_flower_fltr(struct qede_dev *edev, __be16 proto, } /* parse flower attribute and prepare filter */ - if (qede_parse_flow_attr(edev, proto, f->rule, &t)) { - rc = -EINVAL; + rc = qede_parse_flow_attr(edev, proto, f->rule, &t); + if (rc) goto unlock; - } /* Validate profile mode and number of filters */ if ((edev->arfs->filter_count && edev->arfs->mode != t.mode) ||
In qede_add_tc_flower_fltr(), when calling qede_parse_flow_attr() then the return code was only used for a non-zero check, and then -EINVAL was returned. qede_parse_flow_attr() can currently fail with: * -EINVAL * -EOPNOTSUPP * -EPROTONOSUPPORT This patch changes the code to use the actual return code, not just return -EINVAL. The blaimed commit introduced these functions. Only compile tested. Fixes: 2ce9c93eaca6 ("qede: Ingress tc flower offload (drop action) support.") Signed-off-by: Asbjørn Sloth Tønnesen <ast@fiberby.net> --- drivers/net/ethernet/qlogic/qede/qede_filter.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)