| Message ID | 20240426091227.78060-5-ast@fiberby.net (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | f26f719a36e56381a1f4230e5364e7ad4d485888 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: qede: avoid overruling error codes | expand |
On Fri, Apr 26, 2024 at 09:12:26AM +0000, Asbjørn Sloth Tønnesen wrote: > When calling qede_parse_actions() then the > return code was only used for a non-zero check, > and then -EINVAL was returned. > > qede_parse_actions() can currently fail with: > * -EINVAL > * -EOPNOTSUPP > > This patch changes the code to use the actual > return code, not just return -EINVAL. > > The blaimed commit broke the implicit assumption > that only -EINVAL would ever be returned. > > Only compile tested. > > Fixes: 319a1d19471e ("flow_offload: check for basic action hw stats type") > Signed-off-by: Asbjørn Sloth Tønnesen <ast@fiberby.net> Reviewed-by: Simon Horman <horms@kernel.org>
diff --git a/drivers/net/ethernet/qlogic/qede/qede_filter.c b/drivers/net/ethernet/qlogic/qede/qede_filter.c index 377d661f70f7..cb6b33a228ea 100644 --- a/drivers/net/ethernet/qlogic/qede/qede_filter.c +++ b/drivers/net/ethernet/qlogic/qede/qede_filter.c @@ -1894,10 +1894,9 @@ int qede_add_tc_flower_fltr(struct qede_dev *edev, __be16 proto, } /* parse tc actions and get the vf_id */ - if (qede_parse_actions(edev, &f->rule->action, f->common.extack)) { - rc = -EINVAL; + rc = qede_parse_actions(edev, &f->rule->action, f->common.extack); + if (rc) goto unlock; - } if (qede_flow_find_fltr(edev, &t)) { rc = -EEXIST;
When calling qede_parse_actions() then the return code was only used for a non-zero check, and then -EINVAL was returned. qede_parse_actions() can currently fail with: * -EINVAL * -EOPNOTSUPP This patch changes the code to use the actual return code, not just return -EINVAL. The blaimed commit broke the implicit assumption that only -EINVAL would ever be returned. Only compile tested. Fixes: 319a1d19471e ("flow_offload: check for basic action hw stats type") Signed-off-by: Asbjørn Sloth Tønnesen <ast@fiberby.net> --- drivers/net/ethernet/qlogic/qede/qede_filter.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)