From patchwork Tue May 7 18:45:47 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 13657576 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on2055.outbound.protection.outlook.com [40.107.8.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 39D2616F85B; Tue, 7 May 2024 18:47:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.8.55 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715107635; cv=fail; b=SZUb10CNcFWHrvm1jhZUWCSUU/Wnf/7egexhE2KQ1BqnyeGbDJBHMEOyP7VDrnmsYUx32dUgsemtrEh0qcUK2feUNUQJoa0o0Dt0kWPOvkzoZdOvqXBr1Ib/dMA/8HeLk+C1EvnKFMwWcLDdDQEhV5EE9clpBEbhQKrCsez3AY0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715107635; c=relaxed/simple; bh=uRbYV+8P6VjCoxmSQ3mxj6dE+Tuv3Whv1pWoX9EvqFU=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=bmzSGevl6XEMygoInxhFnTAvVsIsnkqGoT+Wzf/Up9pJt9T9xlXGxwhCdm3In0gbKNygdXceKFqaXoepVrZsUprrLi6Kp5DFK/ZPbwZ8ro1UPYTkxCYjZqFFw08K0l5i0FbN5dATZAj77RXuaQEtxHVKZUnKp5mEqvpfN9m1S+w= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b=GGSHFOI+; arc=fail smtp.client-ip=40.107.8.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b="GGSHFOI+" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mXpKnvREYuj7Y72Xc3NUtLx9JXn19fwMT1UQ2LcIHxnnzDZZoGGNLNyKYZBdgnofKeKWS0tqp621LfeMVy2ZBAE+Xke3ieDvv3P+WQmvuw78fyWiri5vZ4XcOMLS2cP5UTa5MUgz90wtAvdEaRygqIafHmbds53lYyJ491yHyf0YSdJ4+mtCC9Aajp0vPQBpexO1+ZoVQcK97VQkAR1eWle8BpvEJS6GG+gH0HXA/XD16oZam416EQgscVEA5+4bzJJB0KSM37zMPHaOOdjV4BtuSaYSr36KYhBgQPlzV7tOIxkAOyhYND2aTb4yA0x7ukoG1ULcwLkwvxytllIngA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IJ8+34n6tB2srgggrSYc9JS7VpTWsMEFMzObdI2BDY4=; b=j2kGg+bhM42UI4jsKC4w+X9TS+jPOuND2TIWXAZVIEhK34X/vCuIuxLUMAmJRgw+hgTruC5mpBXjXoZHxZa1zwuPY1T52WMXCgIVR+m29UUOeNfohwoWEMIfGsmKRpjmQCyV/bbHwaQFDl6CZfvMAWwrX15md4h4CTXBpuf8ayIkomMuVpOlakhXWtTT8taYzQ44nsGx8lLijfuehLFCKUpvGsup08B/6tQ1KY70uHr4ymP2Ik4t2zn3fKOXvZnTUkFiE+6HXARSROG5RpuPnpAfRNMPAPmS8K/0gYuemh4hkdOaMA/NSsEAfIWdcK6MwLwd8//Bi8DYWjgyIvM6+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IJ8+34n6tB2srgggrSYc9JS7VpTWsMEFMzObdI2BDY4=; b=GGSHFOI+41Fg8phLddLCnSE12xkidgN1GUVFW4VWlrjLuTN6QU1Lig/A6TEZoQohNKLs8Eeiaqjy/Vz3QgXxTfzQm5AvMHhecCp/j5FJazoY/VU9lw8dd7wYOUGiAU7PxfHb9gGq7tOesTY6JJPJpyj/4SpaYRG3e5JEhQs50Mo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by DU0PR04MB9636.eurprd04.prod.outlook.com (2603:10a6:10:320::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.41; Tue, 7 May 2024 18:47:11 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::1e67:dfc9:d0c1:fe58]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::1e67:dfc9:d0c1:fe58%7]) with mapi id 15.20.7544.041; Tue, 7 May 2024 18:47:11 +0000 From: Frank Li Date: Tue, 07 May 2024 14:45:47 -0400 Subject: [PATCH v4 09/12] PCI: imx6: Consolidate redundant if-checks Message-Id: <20240507-pci2_upstream-v4-9-e8c80d874057@nxp.com> References: <20240507-pci2_upstream-v4-0-e8c80d874057@nxp.com> In-Reply-To: <20240507-pci2_upstream-v4-0-e8c80d874057@nxp.com> To: Richard Zhu , Lucas Stach , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy?= =?utf-8?q?=C5=84ski?= , Rob Herring , Bjorn Helgaas , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Philipp Zabel , Liam Girdwood , Mark Brown , Manivannan Sadhasivam , Krzysztof Kozlowski , Conor Dooley Cc: linux-pci@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, devicetree@vger.kernel.org, Frank Li X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1715107574; l=1050; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=uRbYV+8P6VjCoxmSQ3mxj6dE+Tuv3Whv1pWoX9EvqFU=; b=3MmPWG8waR7Qnxd0N8fgyHKND+oBRxlIJRVKYtKS5OrYj7pKzRCJ52p106JvTjOIql/eVVDx6 AvFjIssgrH3B9nSVsgDfpFHU5zj2Jdn0SILSp7uOAnm3aRSS6xeIY+n X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: BY5PR17CA0026.namprd17.prod.outlook.com (2603:10b6:a03:1b8::39) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|DU0PR04MB9636:EE_ X-MS-Office365-Filtering-Correlation-Id: e11fba36-25a4-4ffd-2581-08dc6ec61a8e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|1800799015|376005|7416005|52116005|366007|921011|38350700005; X-Microsoft-Antispam-Message-Info: =?utf-8?q?DQ+Q/l0JiehnF2ABw5atm2GFbdKu2VS?= =?utf-8?q?WEMoeSA/bkFkcHlA2CMzd/TCFhS/J+z1RwFaKbGQAFqke4meelpUfWCfKAXlpDu7H?= =?utf-8?q?sVhqaBvRYfyd27LO3bWK+mUD3AfTwEF+YUL4xUgQ+aVc03iTxVuAO5XCJ42a8zuDV?= =?utf-8?q?nst43OEYLgpZH5Uy3F0h/eGN4GSbMPEzXVsef7Fcvo0Ne8o2DbezK0tTW0mYGeClQ?= =?utf-8?q?Iyfpe8bZHfCDLdUdGVYxVKT4vZUkLdBkj+ALUaFQzJV5d0kK88M0/30HfKnhTCuSZ?= =?utf-8?q?W+e3HGlCnPvcNVBB+SoLCYYg8UAV9IpePyOURzjClyFkzXFDrsKZPdSrS/paciIb9?= =?utf-8?q?t17DcQHiIt5Ubv5NlsSjBwrmIcwLknice/mCMEzxapd3C+uWXAR67pc4UBVVTC9sn?= =?utf-8?q?79eZlG0w7v3sm966/zOTjNHpZTpKveBoED8NQKucPRbJZPfiqA29yUNYBYCE2oYo8?= =?utf-8?q?sBkeufhXcY6JtP2QUKyNy9Ug4O8nZxBfZbHjd3v08fA3SWKLzRBrWkVwSB+6xrP/0?= =?utf-8?q?jO4/u9VR+3bP/0AyfC4Qv2jPr+c4aLWx/cAPcyjZBqbp6Wpv0siH0V8NXEUkvaD76?= =?utf-8?q?fZw8s2hXeoDqHNjWRegfZXkNmKxyY9k5nYsbGcDUHVx8ydaxY1A9fXcLiUqQU3F3d?= =?utf-8?q?0STPOLMG36ooBv6dlwPQE00DM5Pdmd2OuiSr5ziiA4n7PW6TNwt2elnAUEhw9DpkK?= =?utf-8?q?Ldzyb3sdgz5lm18ehn5vvBFwAvYGv9Fkb1wUHUfC1qV8GM6Pg9DPPNyDfxzOUTntj?= =?utf-8?q?9p5SnpQuZK4OdfePshZPpLJRovvRXGRvK3GiRq/j4xQxq6pbEadXm9eN7wLwxWps7?= =?utf-8?q?D11+JXrc6NoREigeBFu7NTsvPohVnc3aLGBOrnimZDHNek7XHSHe/zSW5vluXNHcC?= =?utf-8?q?yyfJ4ILgGztCWJvNGxak4Ux53FhiHQF9A5FIGmJc0ftFlbTqrpP6hk3Mxg5OG7axC?= =?utf-8?q?5ixv8MhudGC6b24BKph7QOlP8STOvkkBwXIg4To/rEXvbnO4uVS08+7tgUIk8lU36?= =?utf-8?q?B6p+XECLADtJxnYID2KUQfKPU4WOo4gbBiT6eRWw+bp2h4TViwIt3dXZvuj5CZ6Vm?= =?utf-8?q?F44bXoWA60Ap4c+lBxNN1CQDQV5JGWKUX/vPNy5ZqV+dwBmOUrdlCH7pNikDX2WEM?= =?utf-8?q?42jx0yZSXRNzScIlE52J/Uxo5s6OSjp3v8wXuSpEFnMMPUF4Bop6qIQluNT7PbyjK?= =?utf-8?q?a5k7Shr4QjWDPkSsGjSVxShBLogSYtGGO3cCAsrdKgdq+Y5R/3lnJsw2fknEmXDwB?= =?utf-8?q?oRhfyIgLnOTP3vJtXrR5FvcWvBSzxke/E+AXgSq/ILjzz0SXabmCh7DA=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(1800799015)(376005)(7416005)(52116005)(366007)(921011)(38350700005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?qmRw+0gJENd6Iu6CwNhye4dyY3eD?= =?utf-8?q?4Qm7G9c/7rqyTjM+TuGk8b+I9VpwcaAQsv6+TuF8gzqCBtoMhSDmgiIpdlDGx7Rih?= =?utf-8?q?ckb4tDPoM0HTm8hxJRxqSOGR6PMBiblSrP7nPSpiF5B2cIMUXAm8hIzPYwFyx00wn?= =?utf-8?q?baK+D//8QlUDfcpPikJD/Evt6tGc+QPthnv7S93TCrJE+AFpne5Y3hRqgCLlBKzeQ?= =?utf-8?q?5Xw76ZYsFTG/1oU7axL60enfFajoIqY2IyGEscq/DCzvpkHeWBpE/zd5386QtWHtX?= =?utf-8?q?Ueody7LMgYcA5Q/4wdHFv3hK0gpEUXDDAUgqTDZvwrZJsoXiHiu0qQJyJeg6Jnm7g?= =?utf-8?q?ocFJTCKBFfGB7nheM61blbQd720WoUK1oF7BIuj4jEcYYhX9wDT8nd+XT10WW72Hx?= =?utf-8?q?fXNig/vBZrXFO5phmD0Ta5/Mob+aphypyNURSVicpo3TtCsbchRRjbFArmUGPmn76?= =?utf-8?q?RwgbKFzPMqoejQ9rsULXo2FaemLlFAXTEZyVtOLen4Y0iEcitlMnyq1jcQ3gllLnL?= =?utf-8?q?63CH3jF/PTGyqUmegS54K/fOztOJtab6VFqFs5HiNB71xDH1OmFSJFSSqG0PTOfsN?= =?utf-8?q?KMGjh/jIxUsj/dJBxVlZD3suqgrPhG6lB+Cr1tBdRKBIgunrJ8cMxOSJeIWIA35az?= =?utf-8?q?sDPyeDOLkeCCobMboJHNYMk3hsySvQrrPZ2DBcXI3gn1HFCaVq0kOxm2SmxbCMAv0?= =?utf-8?q?0VYxGVktTyGacS0bRGuQ8o5d3lTDxdv5PGFiozrNnACczPCqX9JzDqOh5AhDHLx6E?= =?utf-8?q?eKIRb09PFd2WsYRr57xwmzNc3RX9u9OLtS1C2jdH79+TQdO23rUyssGIwixjrVs1R?= =?utf-8?q?rna2zGkDCFIwX2YV7ePtRFSL9YFy5adCTmAZkJZtXjJaZskjuBtK4f37vUQP27kwb?= =?utf-8?q?TvW9ceVa0Dq5VMIeuov8orIRzdrfeqX+L4zXEMF8eXfx3t1DoY7gmGtQHU0KYkuFX?= =?utf-8?q?fH+mVCnKCSQCBupIGRm9KbrkD9t2cJSA64ckPkOHEF/6RrQV9d/Pk9WqYhAv2qT4h?= =?utf-8?q?TusTaKqgdp666QZhJcpygauGuSLDVSUPXgX4FrabWyk5L4uG4yd/iCPiB8Cs77n2E?= =?utf-8?q?FvYeM6ARG/ZX36p95b1SZaTiDbS/i+2ZH7Cc3HGF4wYOPPeWSggtlm9nzpYJsq/0z?= =?utf-8?q?51H6E5Jc3NZkRrJMkFEdws0swy2JRTEdIBYvT+mKM1D79rknzQBN11cyoRC9zCVNw?= =?utf-8?q?2ZQq474Togwf85P4dVtY8fjWzRqXNCk5W3mvbrH/LB1oPGprTPDcWfubEgBHWw4zb?= =?utf-8?q?WC+T8JorOCl0ed9wHDHWVNdtw/2YxkmTlB+uH6OsgE+fj/HmlKYRqKTcB1G45DLXK?= =?utf-8?q?Kx/+n4N3cqJyMx5YsgyjTFWNkxWXSEHLrWpuMahHiCaVWGPftAKT2NA9oJ7NhUDIn?= =?utf-8?q?KA2Wr6cq7/guUd049ijnZOI/Yhs7NUS74fcnWq84ZuhNDT597jnKODfw4kNvkV/zv?= =?utf-8?q?VFJRv2wASbsbiuBPzo50ILvJq/Yxx7Kef7kOzbZb0xM6zx4ZT8C+ryMwUkVti8cvs?= =?utf-8?q?vxons0e6k8U8?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: e11fba36-25a4-4ffd-2581-08dc6ec61a8e X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 May 2024 18:47:11.1642 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ouo/zVVN/tohMTENLt1VHAQkdQu0AsDS+fddF3hkweZvusMCxqI4Pqj9kS6zMGMAeluNFQU9+EvayFDzlFEbIA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR04MB9636 Consolidated redundant if-checks pertaining to imx_pcie->phy. Instead of two separate checks, merged them into one to improve code readability. if (imx_pcie->phy) { ... code 1 } if (imx_pcie->phy) { ... code 2 } Merge into one if block. if (imx_pcie->phy) { ... code 1 ... code 2 } Reviewed-by: Manivannan Sadhasivam Signed-off-by: Frank Li --- drivers/pci/controller/dwc/pci-imx6.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c index 66573ef7a002b..9d53b545540c6 100644 --- a/drivers/pci/controller/dwc/pci-imx6.c +++ b/drivers/pci/controller/dwc/pci-imx6.c @@ -1033,9 +1033,7 @@ static int imx_pcie_host_init(struct dw_pcie_rp *pp) dev_err(dev, "pcie PHY power up failed\n"); goto err_clk_disable; } - } - if (imx_pcie->phy) { ret = phy_power_on(imx_pcie->phy); if (ret) { dev_err(dev, "waiting for PHY ready timeout!\n");