From patchwork Sat May 11 03:14:04 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xuan Zhuo X-Patchwork-Id: 13662240 X-Patchwork-Delegate: kuba@kernel.org Received: from out30-118.freemail.mail.aliyun.com (out30-118.freemail.mail.aliyun.com [115.124.30.118]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 210E337171 for ; Sat, 11 May 2024 03:14:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=115.124.30.118 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715397256; cv=none; b=FsRuDvNJeiHRMAtIpiITfgWvNs9usv4Hs32Cs3ejH5hv2Vo1jT2zRO+bcORsul+3LDbMJSARLKqG+FRSf55GY//2elp89nbXb6LjIzub+vUpq1SLTyImyEEtFQz3Wwr2BcICubXbS8CjYop23NqJAotfLfZmq5icsUR0GFnaIYI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715397256; c=relaxed/simple; bh=ewsuyV8kQXxDYRcvuDBSyMwid1myw/6KPQu6KJpCMNU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Oinx4+o8r72nQnWgjMzza4HsqAAkO+JcZUMiE+N2aL6JM0oltTCQPKIBs/tAmVH6C4jtm1ErlaTcRJvxo8JuWHDpOU3Z+TGbfQZD6TfT7r9i7ojDGBaGvvZJgGYfl63M6hkmR18VifhnRovNq57YNdNMAHiaJGumKbBnppkh4QM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com; spf=pass smtp.mailfrom=linux.alibaba.com; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b=b9YkXHgM; arc=none smtp.client-ip=115.124.30.118 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b="b9YkXHgM" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1715397253; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=6pjVpyrOlXGnauDhhKG1ysMrk7xsgBKdl2dWS/Ae8+Q=; b=b9YkXHgMuA+NJfM6O43bxRd5cE1SwGx+uZQxiyMfCohtHKuAy3OUhFUZcW+EE/zoP5Xk0eGcC4p8/oE2c+cOKSA5PFyrUtxhuvLY2dRXrXRDi4YEjUsqoyhtHn9GSeZ1oYAQ9s/WmOEptZ5tuFF0AMQtzZeayldrNmXNrwj7gdI= X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R101e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=maildocker-contentspam033037067109;MF=xuanzhuo@linux.alibaba.com;NM=1;PH=DS;RN=9;SR=0;TI=SMTPD_---0W6By8nu_1715397250; Received: from localhost(mailfrom:xuanzhuo@linux.alibaba.com fp:SMTPD_---0W6By8nu_1715397250) by smtp.aliyun-inc.com; Sat, 11 May 2024 11:14:11 +0800 From: Xuan Zhuo To: netdev@vger.kernel.org Cc: "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , virtualization@lists.linux.dev Subject: [PATCH net-next v5 4/4] virtio_net: remove the misleading comment Date: Sat, 11 May 2024 11:14:04 +0800 Message-Id: <20240511031404.30903-5-xuanzhuo@linux.alibaba.com> X-Mailer: git-send-email 2.32.0.3.g01195cf9f In-Reply-To: <20240511031404.30903-1-xuanzhuo@linux.alibaba.com> References: <20240511031404.30903-1-xuanzhuo@linux.alibaba.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Git-Hash: e1ef52e80115 X-Patchwork-Delegate: kuba@kernel.org We call the build_skb() actually without copying data. The comment is misleading. So remove it. Signed-off-by: Xuan Zhuo Acked-by: Jason Wang --- drivers/net/virtio_net.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 3ffcb2e2185f..f553c09e7ae4 100644 --- a/drivers/net/virtio_net.c +++ b/drivers/net/virtio_net.c @@ -739,7 +739,6 @@ static struct sk_buff *page_to_skb(struct virtnet_info *vi, shinfo_size = SKB_DATA_ALIGN(sizeof(struct skb_shared_info)); - /* copy small packet so we can reuse these pages */ if (!NET_IP_ALIGN && len > GOOD_COPY_LEN && tailroom >= shinfo_size) { skb = virtnet_build_skb(buf, truesize, p - buf, len); if (unlikely(!skb))