diff mbox series

s390/lcs: add missing MODULE_DESCRIPTION() macro

Message ID 20240615-md-s390-drivers-s390-net-v1-1-968cb735f70d@quicinc.com (mailing list archive)
State Superseded
Delegated to: Netdev Maintainers
Headers show
Series s390/lcs: add missing MODULE_DESCRIPTION() macro | expand

Checks

Context Check Description
netdev/tree_selection success Not a local patch

Commit Message

Jeff Johnson June 16, 2024, 4:23 a.m. UTC 
With ARCH=s390, make allmodconfig && make W=1 C=1 reports:
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/s390/net/lcs.o

Add the missing invocation of the MODULE_DESCRIPTION() macro.

Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
---
 drivers/s390/net/lcs.c | 1 +
 1 file changed, 1 insertion(+)


---
base-commit: 83a7eefedc9b56fe7bfeff13b6c7356688ffa670
change-id: 20240615-md-s390-drivers-s390-net-78a9068f1004

Comments

Alexandra Winter June 17, 2024, 7:12 a.m. UTC | #1 
On 16.06.24 06:23, Jeff Johnson wrote:
> With ARCH=s390, make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/s390/net/lcs.o
> 
> Add the missing invocation of the MODULE_DESCRIPTION() macro.
> 
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> ---
>  drivers/s390/net/lcs.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/s390/net/lcs.c b/drivers/s390/net/lcs.c
> index 25d4e6376591..83807ce823e9 100644
> --- a/drivers/s390/net/lcs.c
> +++ b/drivers/s390/net/lcs.c
> @@ -2380,5 +2380,6 @@ module_init(lcs_init_module);
>  module_exit(lcs_cleanup_module);
>  
>  MODULE_AUTHOR("Frank Pavlic <fpavlic@de.ibm.com>");
> +MODULE_DESCRIPTION("S/390 Lan Channel Station Network Driver");
>  MODULE_LICENSE("GPL");
>  
> 
> ---
> base-commit: 83a7eefedc9b56fe7bfeff13b6c7356688ffa670
> change-id: 20240615-md-s390-drivers-s390-net-78a9068f1004
> 
> 


Thank you very much Jeff for noticing this and sending a patch.

I propose to describe the module as
"LAN channel station device driver"
as this is the term and spelling used in the documentation, e.g. here:
https://www.ibm.com/docs/en/linux-on-systems?topic=n-lcs-device-driver-4

Please send a v2
diff mbox series

Patch

diff --git a/drivers/s390/net/lcs.c b/drivers/s390/net/lcs.c
index 25d4e6376591..83807ce823e9 100644
--- a/drivers/s390/net/lcs.c
+++ b/drivers/s390/net/lcs.c
@@ -2380,5 +2380,6 @@  module_init(lcs_init_module);
 module_exit(lcs_cleanup_module);
 
 MODULE_AUTHOR("Frank Pavlic <fpavlic@de.ibm.com>");
+MODULE_DESCRIPTION("S/390 Lan Channel Station Network Driver");
 MODULE_LICENSE("GPL");