| Message ID | 20240625013407.25436-1-lirongqing@baidu.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next,v2,resend] virtio_net: Remove u64_stats_update_begin()/end() for stats fetch | expand |
On Tue, 25 Jun 2024 09:34:07 +0800 Li RongQing wrote: > This place is fetching the stats, u64_stats_update_begin()/end() > should not be used, and the fetcher of stats is in the same context > as the updater of the stats, so don't need any protection > > Acked-by: Michael S. Tsirkin <mst@redhat.com> > Suggested-by: Jakub Kicinski <kuba@kernel.org> > Signed-off-by: Li RongQing <lirongqing@baidu.com> Applied, thanks!
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index b1f8b72..f212977 100644 --- a/drivers/net/virtio_net.c +++ b/drivers/net/virtio_net.c @@ -2382,12 +2382,13 @@ static void virtnet_rx_dim_update(struct virtnet_info *vi, struct receive_queue if (!rq->packets_in_napi) return; - u64_stats_update_begin(&rq->stats.syncp); + /* Don't need protection when fetching stats, since fetcher and + * updater of the stats are in same context + */ dim_update_sample(rq->calls, u64_stats_read(&rq->stats.packets), u64_stats_read(&rq->stats.bytes), &cur_sample); - u64_stats_update_end(&rq->stats.syncp); net_dim(&rq->dim, cur_sample); rq->packets_in_napi = 0;