| Message ID | 20240625173350.1181194-2-sumang@marvell.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | octeontx2-af: Fix klockwork issues in AF driver | expand |
On Tue, 25 Jun 2024 23:03:43 +0530 Suman Ghosh wrote: > Variable "cgx_dev" and "lmac" was getting accessed without NULL checks > which can lead to pointer exception in some erroneous scenarios. > This patch fixes the same by adding the required NULL checks. Please remove the name of the tool from the subject, too. You can add something like: Addresses klockwork warning ${the warning generated or such} at the end of the commit message. If there's a path which can lead to a crash please describe it. If there's no real issue, it's not a fix (no Fixes and net-next). But really, we tend to avoid addressing issues just to please overzealous static code analysis tools. And we advise against defensive programming, so please make sure the patches actually make sense. I don't think patch 6 does, picking a random one to check..
diff --git a/drivers/net/ethernet/marvell/octeontx2/af/cgx.c b/drivers/net/ethernet/marvell/octeontx2/af/cgx.c index 27935c54b91b..e5e266608cfc 100644 --- a/drivers/net/ethernet/marvell/octeontx2/af/cgx.c +++ b/drivers/net/ethernet/marvell/octeontx2/af/cgx.c @@ -465,6 +465,13 @@ u64 cgx_lmac_addr_get(u8 cgx_id, u8 lmac_id) u64 cfg; int id; + if (!cgx_dev) + return 0; + + lmac = lmac_pdata(lmac_id, cgx_dev); + if (!lmac) + return 0; + mac_ops = cgx_dev->mac_ops; id = get_sequence_id_of_lmac(cgx_dev, lmac_id);
Variable "cgx_dev" and "lmac" was getting accessed without NULL checks which can lead to pointer exception in some erroneous scenarios. This patch fixes the same by adding the required NULL checks. Fixes: 96be2e0da85e ("octeontx2-af: Support for MAC address filters in CGX") Signed-off-by: Suman Ghosh <sumang@marvell.com> --- drivers/net/ethernet/marvell/octeontx2/af/cgx.c | 7 +++++++ 1 file changed, 7 insertions(+)