| Message ID | 20240625203145.3962165-1-Frank.Li@nxp.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [1/1] dt-bindings: can: fsl,flexcan: add can-transceiver for fsl,flexcan | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
On 25/06/2024 22:31, Frank Li wrote: > Add 'can-transceiver' children node for fsl,flexcan to allow update > can-transceiver property. I don't understand. Who and how updates can-transceiver property? What is can-transceiver property (I assume you speak about something different than child node)? Best regards, Krzysztof
On Wed, Jun 26, 2024 at 10:19:56AM +0200, Krzysztof Kozlowski wrote: > On 25/06/2024 22:31, Frank Li wrote: > > Add 'can-transceiver' children node for fsl,flexcan to allow update > > can-transceiver property. > > I don't understand. Who and how updates can-transceiver property? What > is can-transceiver property (I assume you speak about something > different than child node)? can-transceiver is chhild node. dts like this &can0 { status = "okay"; can-transceiver { max-bitrate = <5000000>; }; }; Or, I can simple said "Add 'can-transceiver' children node for fsl,flexcan." 'can-transceiver' should be common child node for CAN node. Frank > > > Best regards, > Krzysztof >
On Tue, Jun 25, 2024 at 04:31:45PM -0400, Frank Li wrote: > Add 'can-transceiver' children node for fsl,flexcan to allow update > can-transceiver property. > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > --- > Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml b/Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml > index f197d9b516bb2..d003200247b03 100644 > --- a/Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml > +++ b/Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml > @@ -80,6 +80,9 @@ properties: > node then controller is assumed to be little endian. If this property is > present then controller is assumed to be big endian. > > + can-transceiver: > + $ref: can-transceiver.yaml# unevaluatedProperties: false > + > fsl,stop-mode: > description: | > Register bits of stop mode control. > -- > 2.34.1 >
diff --git a/Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml b/Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml index f197d9b516bb2..d003200247b03 100644 --- a/Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml +++ b/Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml @@ -80,6 +80,9 @@ properties: node then controller is assumed to be little endian. If this property is present then controller is assumed to be big endian. + can-transceiver: + $ref: can-transceiver.yaml# + fsl,stop-mode: description: | Register bits of stop mode control.
Add 'can-transceiver' children node for fsl,flexcan to allow update can-transceiver property. Signed-off-by: Frank Li <Frank.Li@nxp.com> --- Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml | 3 +++ 1 file changed, 3 insertions(+)