| Message ID | 20240701113251.6630-1-liujing@cmss.chinamobile.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | selftest: epoll_busy_poll: remove unnecessary assignment in TEST_F(epoll_busy_poll, test_get_params) | expand |
On Mon, 1 Jul 2024 19:32:51 +0800 Liu Jing wrote: > In the TEST_F(epoll_busy_poll, test_get_params), the initialized value of 'ret' is unused, > because it will be assigned by the ioctl.thus remove it. I don't think this is worth the noise, please don't send such changes to networking.
diff --git a/tools/testing/selftests/net/epoll_busy_poll.c b/tools/testing/selftests/net/epoll_busy_poll.c index 16e457c2f877..652b0957b6c5 100644 --- a/tools/testing/selftests/net/epoll_busy_poll.c +++ b/tools/testing/selftests/net/epoll_busy_poll.c @@ -130,7 +130,7 @@ TEST_F(epoll_busy_poll, test_get_params) * the default should be default and all fields should be zero'd by the * kernel, so set params fields to garbage to test this. */ - int ret = 0; + int ret; self->params.busy_poll_usecs = 0xff; self->params.busy_poll_budget = 0xff;
In the TEST_F(epoll_busy_poll, test_get_params), the initialized value of 'ret' is unused, because it will be assigned by the ioctl.thus remove it. Signed-off-by: Liu Jing <liujing@cmss.chinamobile.com> --- tools/testing/selftests/net/epoll_busy_poll.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)