| Message ID | 20240703112502.28021-1-marcin.szycik@linux.intel.com (mailing list archive) |
|---|---|
| State | Awaiting Upstream |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [iwl-next] ice: Fix field vector array data type | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Guessing tree name failed - patch did not apply |
On Wed, Jul 03, 2024 at 01:25:02PM +0200, Marcin Szycik wrote: > Correct the datatype of fv_idx array in struct ice_sw_recipe to be u8 > instead of u16. This array contents are used solely to be later passed > to lkup_indx in struct ice_aqc_recipe_content, which is u8. > > Fixes: 6d82b8eda4c7 ("ice: Optimize switch recipe creation") > Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com> > Signed-off-by: Marcin Szycik <marcin.szycik@linux.intel.com> > --- > Targeting next, as the commit to be fixed is on dev-queue. > Tony, please squash this with commit 6d82b8eda4c7 ("ice: Optimize switch recipe creation") FWIIW, this LGTM. ...
diff --git a/drivers/net/ethernet/intel/ice/ice_switch.h b/drivers/net/ethernet/intel/ice/ice_switch.h index 3e4af531b875..671d7a5f359f 100644 --- a/drivers/net/ethernet/intel/ice/ice_switch.h +++ b/drivers/net/ethernet/intel/ice/ice_switch.h @@ -226,7 +226,7 @@ struct ice_sw_recipe { */ struct ice_fv_word ext_words[ICE_MAX_CHAIN_WORDS]; u16 word_masks[ICE_MAX_CHAIN_WORDS]; - u16 fv_idx[ICE_MAX_CHAIN_WORDS]; + u8 fv_idx[ICE_MAX_CHAIN_WORDS]; u16 fv_mask[ICE_MAX_CHAIN_WORDS]; /* Bit map specifying the IDs associated with this group of recipe */
Correct the datatype of fv_idx array in struct ice_sw_recipe to be u8 instead of u16. This array contents are used solely to be later passed to lkup_indx in struct ice_aqc_recipe_content, which is u8. Fixes: 6d82b8eda4c7 ("ice: Optimize switch recipe creation") Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com> Signed-off-by: Marcin Szycik <marcin.szycik@linux.intel.com> --- Targeting next, as the commit to be fixed is on dev-queue. Tony, please squash this with commit 6d82b8eda4c7 ("ice: Optimize switch recipe creation") --- drivers/net/ethernet/intel/ice/ice_switch.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)