| Message ID | 20240703132801.623218-1-o.rempel@pengutronix.de (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net,v1,1/2] net: phy: microchip: lan87xx: reinit PHY after cable test | expand |
On Wed, Jul 03, 2024 at 03:28:00PM +0200, Oleksij Rempel wrote: > Reinit PHY after cable test, otherwise link can't be established on > tested port. This issue is reproducible on LAN9372 switches with > integrated 100BaseT1 PHYs. > > Fixes: 788050256c411 ("net: phy: microchip_t1: add cable test support for lan87xx phy") > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> > --- > drivers/net/phy/microchip_t1.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/phy/microchip_t1.c b/drivers/net/phy/microchip_t1.c > index a838b61cd844b..a35528497a576 100644 > --- a/drivers/net/phy/microchip_t1.c > +++ b/drivers/net/phy/microchip_t1.c > @@ -748,7 +748,7 @@ static int lan87xx_cable_test_report(struct phy_device *phydev) > ethnl_cable_test_result(phydev, ETHTOOL_A_CABLE_PAIR_A, > lan87xx_cable_test_report_trans(detect)); > > - return 0; > + return phy_init_hw(phydev); > } > > static int lan87xx_cable_test_get_status(struct phy_device *phydev, > -- > 2.39.2 > > Thanks, Reviewed-by: Michal Kubiak <michal.kubiak@intel.com>
On Wed, Jul 03, 2024 at 03:28:00PM +0200, Oleksij Rempel wrote: > Reinit PHY after cable test, otherwise link can't be established on > tested port. This issue is reproducible on LAN9372 switches with > integrated 100BaseT1 PHYs. Since this is a patchset, a cover letter would be normal. > > Fixes: 788050256c411 ("net: phy: microchip_t1: add cable test support for lan87xx phy") > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
On 7/3/2024 2:28 PM, Oleksij Rempel wrote: > Reinit PHY after cable test, otherwise link can't be established on > tested port. This issue is reproducible on LAN9372 switches with > integrated 100BaseT1 PHYs. > > Fixes: 788050256c411 ("net: phy: microchip_t1: add cable test support for lan87xx phy") > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
On 7/3/2024 2:28 PM, Oleksij Rempel wrote: > Reinit PHY after cable test, otherwise link can't be established on > tested port. This issue is reproducible on LAN9372 switches with > integrated 100BaseT1 PHYs. > > Fixes: 788050256c411 ("net: phy: microchip_t1: add cable test support for lan87xx phy") > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
diff --git a/drivers/net/phy/microchip_t1.c b/drivers/net/phy/microchip_t1.c index a838b61cd844b..a35528497a576 100644 --- a/drivers/net/phy/microchip_t1.c +++ b/drivers/net/phy/microchip_t1.c @@ -748,7 +748,7 @@ static int lan87xx_cable_test_report(struct phy_device *phydev) ethnl_cable_test_result(phydev, ETHTOOL_A_CABLE_PAIR_A, lan87xx_cable_test_report_trans(detect)); - return 0; + return phy_init_hw(phydev); } static int lan87xx_cable_test_get_status(struct phy_device *phydev,
Reinit PHY after cable test, otherwise link can't be established on tested port. This issue is reproducible on LAN9372 switches with integrated 100BaseT1 PHYs. Fixes: 788050256c411 ("net: phy: microchip_t1: add cable test support for lan87xx phy") Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> --- drivers/net/phy/microchip_t1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)