| Message ID | 20240704053123.967930-1-o.rempel@pengutronix.de (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net,v2,1/1] net: phy: microchip: lan87xx: reinit PHY after cable test | expand |
On Thu, Jul 04, 2024 at 07:31:23AM +0200, Oleksij Rempel wrote: > Reinit PHY after cable test, otherwise link can't be established on > tested port. This issue is reproducible on LAN9372 switches with > integrated 100BaseT1 PHYs. > > Fixes: 788050256c411 ("net: phy: microchip_t1: add cable test support for lan87xx phy") > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> > Reviewed-by: Andrew Lunn <andrew@lunn.ch> I lost in this version one reviewed by: Reviewed-by: Michal Kubiak <michal.kubiak@intel.com>
diff --git a/drivers/net/phy/microchip_t1.c b/drivers/net/phy/microchip_t1.c index a838b61cd844b..a35528497a576 100644 --- a/drivers/net/phy/microchip_t1.c +++ b/drivers/net/phy/microchip_t1.c @@ -748,7 +748,7 @@ static int lan87xx_cable_test_report(struct phy_device *phydev) ethnl_cable_test_result(phydev, ETHTOOL_A_CABLE_PAIR_A, lan87xx_cable_test_report_trans(detect)); - return 0; + return phy_init_hw(phydev); } static int lan87xx_cable_test_get_status(struct phy_device *phydev,
Reinit PHY after cable test, otherwise link can't be established on tested port. This issue is reproducible on LAN9372 switches with integrated 100BaseT1 PHYs. Fixes: 788050256c411 ("net: phy: microchip_t1: add cable test support for lan87xx phy") Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> Reviewed-by: Andrew Lunn <andrew@lunn.ch> --- changes v2: - add Reviewed-by: Andrew Lunn <andrew@lunn.ch> - drop microchip specific SQI fix drivers/net/phy/microchip_t1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)