Message ID | 20240730012506.3317978-4-shaozhengchao@huawei.com (mailing list archive) |
---|---|
State | Accepted |
Commit | d37307eaac13f3c5fe912787b5f9facbc574f2cf |
Delegated to: | Netdev Maintainers |
Headers | show |
Series | net/smc: do some cleanups in smc module | expand |
On Tue, Jul 30, 2024 at 09:25:05AM +0800, Zhengchao Shao wrote: > When the SMC client perform CLC handshake, it will check whether > the clc header type is correct in receiving SMC_CLC_ACCEPT packet. > The specific invoking path is as follows: > __smc_connect > smc_connect_clc > smc_clc_wait_msg > smc_clc_msg_hdr_valid > smc_clc_msg_acc_conf_valid > Therefore, the smc_connect_check_aclc interface invoked by > __smc_connect does not need to check type again. > > Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com> Thanks, I agree that in the case of a SMC_CLC_ACCEPT packet, which is the case here, this check is unnecessary as it has already been performed by smc_clc_msg_acc_conf_valid(). Reviewed-by: Simon Horman <horms@kernel.org>
diff --git a/net/smc/af_smc.c b/net/smc/af_smc.c index 83f5a1849971..6f82e4d8fda4 100644 --- a/net/smc/af_smc.c +++ b/net/smc/af_smc.c @@ -1466,10 +1466,6 @@ static int smc_connect_ism(struct smc_sock *smc, static int smc_connect_check_aclc(struct smc_init_info *ini, struct smc_clc_msg_accept_confirm *aclc) { - if (aclc->hdr.typev1 != SMC_TYPE_R && - aclc->hdr.typev1 != SMC_TYPE_D) - return SMC_CLC_DECL_MODEUNSUPP; - if (aclc->hdr.version >= SMC_V2) { if ((aclc->hdr.typev1 == SMC_TYPE_R && !smcr_indicated(ini->smc_type_v2)) ||
When the SMC client perform CLC handshake, it will check whether the clc header type is correct in receiving SMC_CLC_ACCEPT packet. The specific invoking path is as follows: __smc_connect smc_connect_clc smc_clc_wait_msg smc_clc_msg_hdr_valid smc_clc_msg_acc_conf_valid Therefore, the smc_connect_check_aclc interface invoked by __smc_connect does not need to check type again. Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com> --- net/smc/af_smc.c | 4 ---- 1 file changed, 4 deletions(-)