diff mbox series

[net,v2] net/smc: add the max value of fallback reason count

Message ID 20240805043856.565677-1-shaozhengchao@huawei.com (mailing list archive)
State Accepted
Commit d27a835f41d947f62e6a95e89ba523299c9e6437
Delegated to: Netdev Maintainers
Headers show
Series [net,v2] net/smc: add the max value of fallback reason count | expand

Checks

Context Check Description
netdev/series_format success Single patches do not need cover letters
netdev/tree_selection success Clearly marked for net
netdev/ynl success Generated files up to date; no warnings/errors; no diff in generated;
netdev/fixes_present success Fixes tag present in non-next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 29 this patch: 29
netdev/build_tools success No tools touched, skip
netdev/cc_maintainers success CCed 11 of 11 maintainers
netdev/build_clang success Errors and warnings before: 29 this patch: 29
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success Fixes tag looks correct
netdev/build_allmodconfig_warn success Errors and warnings before: 29 this patch: 29
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 8 lines checked
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0
netdev/contest success net-next-2024-08-06--00-00 (tests: 707)

Commit Message

shaozhengchao Aug. 5, 2024, 4:38 a.m. UTC
The number of fallback reasons defined in the smc_clc.h file has reached
36. For historical reasons, some are no longer quoted, and there's 33
actually in use. So, add the max value of fallback reason count to 36.

Fixes: 6ac1e6563f59 ("net/smc: support smc v2.x features validate")
Fixes: 7f0620b9940b ("net/smc: support max connections per lgr negotiation")
Fixes: 69b888e3bb4b ("net/smc: support max links per lgr negotiation in clc handshake")
Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
---
v2: add fix tag and change max value to 36
---
 net/smc/smc_stats.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Wenjia Zhang Aug. 5, 2024, 7:53 a.m. UTC | #1
On 05.08.24 06:38, Zhengchao Shao wrote:
> The number of fallback reasons defined in the smc_clc.h file has reached
> 36. For historical reasons, some are no longer quoted, and there's 33
> actually in use. So, add the max value of fallback reason count to 36.
> 
> Fixes: 6ac1e6563f59 ("net/smc: support smc v2.x features validate")
> Fixes: 7f0620b9940b ("net/smc: support max connections per lgr negotiation")
> Fixes: 69b888e3bb4b ("net/smc: support max links per lgr negotiation in clc handshake")
> Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
> ---
> v2: add fix tag and change max value to 36
> ---
>   net/smc/smc_stats.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/smc/smc_stats.h b/net/smc/smc_stats.h
> index 9d32058db2b5..e19177ce4092 100644
> --- a/net/smc/smc_stats.h
> +++ b/net/smc/smc_stats.h
> @@ -19,7 +19,7 @@
>   
>   #include "smc_clc.h"
>   
> -#define SMC_MAX_FBACK_RSN_CNT 30
> +#define SMC_MAX_FBACK_RSN_CNT 36
>   
>   enum {
>   	SMC_BUF_8K,

It looks good to me!

Reviewed-by: Wenjia Zhang <wenjia@linux.ibm.com>
D. Wythe Aug. 5, 2024, 7:59 a.m. UTC | #2
On 8/5/24 12:38 PM, Zhengchao Shao wrote:
> The number of fallback reasons defined in the smc_clc.h file has reached
> 36. For historical reasons, some are no longer quoted, and there's 33
> actually in use. So, add the max value of fallback reason count to 36.
>
> Fixes: 6ac1e6563f59 ("net/smc: support smc v2.x features validate")
> Fixes: 7f0620b9940b ("net/smc: support max connections per lgr negotiation")
> Fixes: 69b888e3bb4b ("net/smc: support max links per lgr negotiation in clc handshake")
> Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
> ---
> v2: add fix tag and change max value to 36
> ---
>   net/smc/smc_stats.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/smc/smc_stats.h b/net/smc/smc_stats.h
> index 9d32058db2b5..e19177ce4092 100644
> --- a/net/smc/smc_stats.h
> +++ b/net/smc/smc_stats.h
> @@ -19,7 +19,7 @@
>   
>   #include "smc_clc.h"
>   
> -#define SMC_MAX_FBACK_RSN_CNT 30
> +#define SMC_MAX_FBACK_RSN_CNT 36
>   
>   enum {
>   	SMC_BUF_8K,

LGTM. Thanks

Reviewed-by: D. Wythe <alibuda@linux.alibaba.com>
patchwork-bot+netdevbpf@kernel.org Aug. 8, 2024, 3:30 a.m. UTC | #3
Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Mon, 5 Aug 2024 12:38:56 +0800 you wrote:
> The number of fallback reasons defined in the smc_clc.h file has reached
> 36. For historical reasons, some are no longer quoted, and there's 33
> actually in use. So, add the max value of fallback reason count to 36.
> 
> Fixes: 6ac1e6563f59 ("net/smc: support smc v2.x features validate")
> Fixes: 7f0620b9940b ("net/smc: support max connections per lgr negotiation")
> Fixes: 69b888e3bb4b ("net/smc: support max links per lgr negotiation in clc handshake")
> Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
> 
> [...]

Here is the summary with links:
  - [net,v2] net/smc: add the max value of fallback reason count
    https://git.kernel.org/netdev/net/c/d27a835f41d9

You are awesome, thank you!
diff mbox series

Patch

diff --git a/net/smc/smc_stats.h b/net/smc/smc_stats.h
index 9d32058db2b5..e19177ce4092 100644
--- a/net/smc/smc_stats.h
+++ b/net/smc/smc_stats.h
@@ -19,7 +19,7 @@ 
 
 #include "smc_clc.h"
 
-#define SMC_MAX_FBACK_RSN_CNT 30
+#define SMC_MAX_FBACK_RSN_CNT 36
 
 enum {
 	SMC_BUF_8K,